code-review don't create try pushes for old phabricator revisions

If reviewbot fails to create a try push for a given phabricator revision in some time (1 hour?), it should give up instead of holding on to it forever.

We're seeing an issue right now where reviewbot is delayed making try pushes by 2 days.

Mar 21 '24 12:03 jcristau

This would be fixed around here: https://github.com/mozilla/libmozevent/blob/a41fad391146bbdc182b3bcc295353c30f76bfbc/libmozevent/mercurial.py#L357.

Mar 21 '24 12:03 marco-c

We should return a failure and post to Phab that we run out of time.

Mar 21 '24 12:03 marco-c

we should check the age of the build there as there are other stop conditions
the age is obtainable through PhabricatorBuild.diff.[some path in JSON]

Oct 21 '24 07:10 La0

Side note: we need this patch to test deployment of #2449 (if we need to get some downtime, it will spam with try pushes otherwise)

Oct 24 '24 07:10 La0

This is fixed in libmozevent, we just need to upgrade the lib.

Oct 24 '24 09:10 marco-c

The usage of this patch in events gives this Sentry issue

Nov 25 '24 19:11 La0

I made a cleaner version of build expiry check, adding a new state on the build, and custom error messages.

These 2 PRs still require some unit tests

Nov 26 '24 12:11 La0

@Archaeopteryx could you review https://github.com/mozilla/libmozevent/pull/109 then we need to build a libmozevent release (should just be a tag push) and use it in #2550

Dec 06 '24 10:12 La0