try-comm-central code-review results not reported

[jfx2006]

It looks like the bot needs to know about the new comm-unified repository.

https://firefox-ci-tc.services.mozilla.com/tasks/ChccDnINRpWxOCdRPstHdg/runs/0/logs/public/logs/live.log

2024-01-16 19:04:47.000265 [WARNING ] Backend rejected the payload: b'{"base_repository":["Object with url=https://hg.mozilla.org/comm-unified does not exist."]}'
2024-01-16 19:04:47.000275 [ERROR   ] Static analysis failure | extra={'revision': PHID-DIFF-jonkpeqnid5d46vgdawy, 'error': AssertionError('Stopping early because revision could not be created nor retrieved from the backend')

COMM_BASE_REPOSITORY is now set to use https://hg.mozilla.org/comm-unified.

[marco-c]

Here's the current config:

    - checkout: robust
      try_url: ssh://hg.mozilla.org/try-comm-central
      try_mode: json
      try_name: try-comm-central
      name: comm-central
      ssh_user: reviewbot
      url: https://hg.mozilla.org/comm-central
      decision_env_revision: COMM_HEAD_REV
      decision_env_repository: COMM_HEAD_REPOSITORY
      decision_env_prefix: COMM

Should we only change https://hg.mozilla.org/comm-central to https://hg.mozilla.org/comm-unified?

[jfx2006]

I am not sure. comm-unified is built the same way as mozilla-unified so it has all of the revisions from comm-central, c-beta, c-release, and c-esr*. With the exception of comm-esr115, all of the CI jobs are now using comm-unified as COMM_BASE_REPOSITORY instead of comm-central.

I'm guessing what needs to happen based on the error message in the log.

[marco-c]

Done, we should see it working after the next restart of the service.

[marco-c]

@jfx2006 is it working now?

[jfx2006]

As of earlier today it's not working.

If I query the backend I don't see comm-unified. https://api.code-review.moz.tools/v1/repository/

[coreycb]

Hey @marco-c Could you take a look at this again? It seems it didn't get resolved.

[marco-c]

@coreycb we're working on a few improvements for the bot, we will investigate this again soon.

[marco-c]

I see the following in the logs:

Oct 29 22:26:24 [34.19.26.8](https://my.papertrailapp.com/systems/14229533590/events?focus=1788046735835279360&selected=1788046735835279360) [code-review/production/bot](https://my.papertrailapp.com/events?q=program%3Acode-review%2Fproduction%2Fbot&focus=1788046735835279360&selected=1788046735835279360) 2024-10-29 22:26:24 backend.py: [warning  ] Backend rejected the payload: b'{"base_repository":["Object with url=https://hg.mozilla.org/comm-unified does not exist."]}'

[marco-c]

We likely need to add the repo to the DB, just like #985 (and we should finally document this better, see #988).