bugbug icon indicating copy to clipboard operation
bugbug copied to clipboard

Add tests for repository._transform

Open marco-c opened this issue 6 years ago • 17 comments

Also change the function name, since we're there.

marco-c avatar May 09 '19 23:05 marco-c

I would like to work on this , could you please assign this me @marco-c

rajibmitra avatar May 14 '19 14:05 rajibmitra

@rajibmitra feel free to work on it! Issues are assigned automatically when there is a PR to fix them.

marco-c avatar May 14 '19 14:05 marco-c

hello I would like to work on this issue, could you give me some pointers on where to get started? Thanks!

Iantonga avatar Nov 10 '19 19:11 Iantonga

@lantonga we need to add tests for the _transform function of the repository module.

marco-c avatar Nov 10 '19 19:11 marco-c

Can someone more intimate with the _transform function either add comments to the file or give us pseudo code / an oversimplification so we can start understanding it?

Nathan-Wisner avatar Nov 30 '19 05:11 Nathan-Wisner

The function is analyzing a commit and gathering a few metrics from it. What parts of the function are not clear? If you have specific doubts I can help clarifying them.

marco-c avatar Dec 01 '19 11:12 marco-c

I'm having trouble installing rs_parsepatch. I installed all dependencies from requirements.txt and test-requirements.txt except rs_parsepatch. This is the error I'm getting:

error1 error2 image

alihaiderrizvi avatar Mar 13 '21 10:03 alihaiderrizvi

@alihaiderrizvi from the error, it looks like you need to install Visual Studio.

marco-c avatar Mar 13 '21 11:03 marco-c

I installed Visual Studio, and now I'm getting the following error: error1 error2

alihaiderrizvi avatar Mar 14 '21 18:03 alihaiderrizvi

Try setting Rust nightly as your default

marco-c avatar Mar 14 '21 18:03 marco-c

That worked! rs_parsepatch is installed. However, when I ran pytest on tests/test_repository.py, many tests return the following error: Exception: rust-code-analysis is required for code analysis error Am I missing a dependency?

alihaiderrizvi avatar Mar 14 '21 20:03 alihaiderrizvi

Yes, you will need to install rust-code-analysis. You can install it by using Cargo: cargo install rust-code-analysis-web.

marco-c avatar Mar 14 '21 23:03 marco-c

I think I've messed up somewhere while setting up the project because the errors just don't stop 🤦‍♂️ error1 The TypeError is coming from the following function: error2 Apologies for "bugging" too much, this is my first shot at OS contribution.

alihaiderrizvi avatar Mar 15 '21 19:03 alihaiderrizvi

@alihaiderrizvi I'd suggest using Linux or a Linux VM, you'll have a much easier life.

marco-c avatar Mar 15 '21 21:03 marco-c

Is this issue open? I would like to work on this.

ria-19 avatar Oct 22 '21 15:10 ria-19

Yes, it's still open.

marco-c avatar Oct 22 '21 15:10 marco-c

Thank you, I'll soon update you with the work.

ria-19 avatar Oct 22 '21 16:10 ria-19