bedrock icon indicating copy to clipboard operation
bedrock copied to clipboard

Prefer win64 full installer on /installer-help/ when appropriate

Open amychurchwell opened this issue 5 years ago • 6 comments

Description

(bug 1564333)

Currently, when an user lands on https://www.mozilla.org/firefox/installer-help/?channel=release, they always get a win32 full installer, even if the stub installer finds their Windows OS to be compatible with win64 builds of Firefox.

┆Issue is synchronized with this Jira Task ┆Priority: (none) ┆Sprint: Backlog

amychurchwell avatar Mar 09 '20 15:03 amychurchwell

I want to work on this issue

grininja avatar May 19 '20 05:05 grininja

This appears to have been corrected. @Errolyn just tested with their Win64 bit build machine and found that the proper, expected Win64 bit build was provided.

ejregithub avatar Aug 04 '20 18:08 ejregithub

As far as I know this was never fixed on the bedrock side, so I’m very curious as to how the 64bit build is being provided?

alexgibson avatar Aug 04 '20 19:08 alexgibson

And blah . . . this remains, obviously. Thank you for confirming @alexgibson. I tested on my wife's Win64 bit and was provided the 32bit version of Firefox.

ejregithub avatar Aug 05 '20 00:08 ejregithub

Depends on https://bugzilla.mozilla.org/show_bug.cgi?id=1621749

alexgibson avatar May 10 '23 08:05 alexgibson

Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1621749 has been fixed, so this is actually ready to work on I think!

The new installer_arch parameter should now provide the following hints to the /installer-help/ page:

  1. if installer_arch=1 we should serve Windows 32bit installer.
  2. If installer_arch=2 we should serve the Windows 64bit installer.
  3. If installer_arch=3 we should serve the Windows AARCH64 installer.

If the installer_arch parameter is not present (i.e. unknown), we can assume to show links to the Windows 32bit installer.

alexgibson avatar Jun 12 '24 13:06 alexgibson