bedrock icon indicating copy to clipboard operation
bedrock copied to clipboard

New MVP footer has `<hr>` element adding extra space

Open reemhamz opened this issue 1 year ago • 2 comments

Description

The new MVP footer's pixelated design is only available on the home and about pages. However, on other pages that don't have it, there's an extra space from a leftover <hr> element

Steps to reproduce

  • Go to a random page that isn't the home or about page (i.e. http://localhost:8000/en-US/advertising/)
  • Scroll all the way to the bottom of the page
  • Notice a grey horizontal line (<hr>) that's floating above the black footer with extra spacing above and below it.

Expected result

No <hr> element or space around it:

Screenshot 2024-09-16 at 4 19 03 PM

Actual result

An <hr> element with space around it: Screenshot 2024-09-16 at 4 15 27 PM

What happened.

Environment

MacOS Sonoma 14.6.1, Firefox 130.0

reemhamz avatar Sep 16 '24 06:09 reemhamz

I think the right thing to do here is to add the styles that transform the hr into the pixelated line. I think that means adding them to the footer's CSS files.

stephaniehobson avatar Sep 16 '24 20:09 stephaniehobson

I have tried adding the transition divider styling everywhere in #15194, but… some pages that end with colour shapes don't work well with that, like:

Screenshot 2024-09-22 at 19 10 59

Screenshot 2024-09-22 at 17 45 17

Screenshot 2024-09-22 at 19 24 32

Hiding the hr for now with low specificity .m24-c-transition * { display: none; } (that's only effective until the proper declaration is loaded) looks perhaps better — but that doesn't solve the issue once 2024 styles are turned on site-wide — when that divider gets styled globally and places with somewhat rectangular blocks ending the pages will display like this anyway…

janbrasna avatar Sep 22 '24 17:09 janbrasna