Gcs database
One-line summary
Allow uploading and downloading from GCP CS (GCS) instead of AWS S3.
Significant changes and points to review
I felt like just throwing an error during the upload if there was a failure is fine but let me know if you want me to try to figure out what to catch.
Issue / Bugzilla link
https://github.com/mozilla/bedrock/issues/12637
Testing
I deployed the change manually in our dev gcp environment and connected to the clock pod to manually run an upload and a download.
Looks like ./bin/cron.py imports it but there's a path that is added in that one for it to work.
Thanks @robhudson !
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 76.88%. Comparing base (
a9a2f04) to head (b7ca03a). Report is 799 commits behind head on main.
:exclamation: Current head b7ca03a differs from pull request most recent head c3b0cc5
Please upload reports for the commit c3b0cc5 to get more accurate results.
Additional details and impacted files
@@ Coverage Diff @@
## main #12817 +/- ##
==========================================
- Coverage 76.99% 76.88% -0.12%
==========================================
Files 144 144
Lines 7704 7669 -35
==========================================
- Hits 5932 5896 -36
- Misses 1772 1773 +1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@bkochendorfer Do you need one of us to merge this?
Yes I do not have merge capabilities here
Chatted with Brett. We're going to sit on this until there's a bit more time to focus on it soon.
I'm going to close this but feel free to re-open with an updated version :)