bedrock icon indicating copy to clipboard operation
bedrock copied to clipboard

migrate pocket hits signup (Fixes #10756)

Open nathan-barrett opened this issue 4 years ago • 4 comments

Description

This is just the Front end for the pocket hits sign up page - not sure how we will end up handling the email validation and form submission. Since the FE is finished, I wanted to get some eyes on it so that when the back end is finished it could be merged.

Issue / Bugzilla link

#10756

Testing

localhost:8000/external/pocket/explore/pocket-hits-signup

nathan-barrett avatar Dec 08 '21 00:12 nathan-barrett

Codecov Report

Merging #10885 (6385810) into master (851fa26) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10885   +/-   ##
=======================================
  Coverage   76.22%   76.22%           
=======================================
  Files         146      146           
  Lines        7280     7280           
=======================================
  Hits         5549     5549           
  Misses       1731     1731           
Impacted Files Coverage Δ
bedrock/externalpages/urls.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 851fa26...6385810. Read the comment docs.

codecov[bot] avatar Dec 29 '21 18:12 codecov[bot]

@nathan-barrett Is this page still current in terms of Pocket mode, or can we close this PR, please?

stevejalim avatar Jun 13 '22 18:06 stevejalim

@stevejalim I wasn't sure what to do here actually - since we were waiting on the pocket hits being moved to basket (still not sure on the status) So i waited on publishing this PR - but not sure the best route to take here. cc: @slightlyoffbeat Any idea on the status of the pocket hits mailing list to use basket?

nathan-barrett avatar Jun 13 '22 18:06 nathan-barrett

Pocket hits will not be moving to basket. Pocket team will be using Braze: https://www.braze.com/docs

We should pause on this page and re-gather the new requirements from the pocket front end team and see how to best move forward.

slightlyoffbeat avatar Jun 14 '22 00:06 slightlyoffbeat