bedrock icon indicating copy to clipboard operation
bedrock copied to clipboard

[Epic] evolve static getpocket.com pages

Open slightlyoffbeat opened this issue 4 years ago • 9 comments

Description

We are in the process of migrating the marketing pocket pages to the externalpages/pocket directory within bedrock.

With the pages in bedrock we can leverage the existing l10n and asset pipelines, and any changes will be much easier with jinja templates.

Success Critera

Front-end tasks

  • [x] Incorporate JS from pocket repo (if needed)
  • [x] #10783
  • [x] #11171 (relevant JS)

Migrate the following pages:

  • [x] about
  • [x] add
  • [x] #10749
  • [x] #10750
  • [x] #10755
  • [x] #10751
  • [ ] #10756 - Blocked
  • [x] #10757
  • [x] #10758
  • [x] #10752
  • [x] #10759
  • [x] #10753
  • [x] #10760
  • [ ] #10761 - Blocked
  • [x] #10762
  • [x] #10754
  • [x] #10764
  • [x] #10763
  • [x] #10767

Sub-epics

  • [ ] https://github.com/mozilla/bedrock/issues/11403

Backend tasks

  • [ ] Ensure the supported locales match with the supported Pocket locales
  • [ ] Add appropriate FTL files for localized content
  • [ ] Ensure the FTL file path is included in the l10n/configs/vendor.toml file
  • [ ] Update documentation to include information about the externalpages app
  • [ ] Write some tests for the backend
  • [ ] Consider a middleware to catch/log any redirects coming from bedrock for external pages (these will break the URL for the end user)

slightlyoffbeat avatar May 20 '21 06:05 slightlyoffbeat

Doc detailing our next steps and action plan: https://docs.google.com/document/d/1gqSpl2K6EpZOfzOZeMni0cC-9KM-HjnwGmK9--QjgLw/edit

reemhamz avatar Sep 20 '21 14:09 reemhamz

May be able to borrow bedrock code for fluent files. Current estimate is 1 week.

slightlyoffbeat avatar Oct 07 '21 15:10 slightlyoffbeat

@slightlyoffbeat lets get access to the pocket repo to get the pre-compiled styles

slightlyoffbeat avatar Oct 14 '21 15:10 slightlyoffbeat

2 pages to solve for:

  • Pocket hits signup page
  • Pocket hits confirmation page

@slightlyoffbeat to talk to Tina.

slightlyoffbeat avatar Dec 09 '21 16:12 slightlyoffbeat

Question for analytics: do we need to migrate the snowplow script over for these pages as well? (right now there's a mozilla cookie helper script that has no use without snowplow: https://github.com/mozilla/bedrock/issues/11123)

maureenlholland avatar Jan 17 '22 12:01 maureenlholland

Yes I believe we do need snowplow still.

pmac avatar Jan 17 '22 17:01 pmac

Yes, snowplow should be considered a requirement.

slightlyoffbeat avatar Jan 19 '22 00:01 slightlyoffbeat

@reemhamz @slightlyoffbeat Naive question: is the pocket index/root page being ported, too, please?

stevejalim avatar Apr 01 '22 20:04 stevejalim

Yes, the logged-out homepage is being ported.

slightlyoffbeat avatar Apr 01 '22 20:04 slightlyoffbeat

@stevejalim want to do the honours and close this one out? 🎉

alexgibson avatar Oct 20 '22 16:10 alexgibson