authenticator-rs Allow disabling C API exports

This PR allows downstream users to disable the compilation of the C API exposed by authenticator. These may not be used by pure Rust projects and the inclusion of them causes unneeded noise in some crash/stack backtraces.

The exposure of these was moved behind a feature flag to solve this problem. It is enabled by default to remain compatible with anyone who may have been relying on them.

Jun 22 '22 16:06 complexspaces

@msirringhaus Friendly ping on this one, if you have the bandwidth.

Jul 26 '22 21:07 complexspaces

I don't have any permissions on this repo :) But honestly, I also don't fully understand the problem the C-API is causing. How would unused code create noise in backtraces?

Jul 27 '22 06:07 msirringhaus

With the removal of the API entirely in https://github.com/mozilla/authenticator-rs/pull/250, this PR is now irrelevant AFAICT. I'll go ahead and close this.

Jun 08 '23 06:06 complexspaces

How would unused code create noise in backtraces?

A lot of crash dumps/symbolicators list exported symbols in dynamic libraries, and the C API caused multiple to be present.

Jun 08 '23 06:06 complexspaces