application-services icon indicating copy to clipboard operation
application-services copied to clipboard

Switch suggest component from UDL to proc-macros

Open gruberb opened this issue 1 year ago • 1 comments

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • [ ] This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • [ ] Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • [ ] Tests: This PR includes thorough tests or an explanation of why it does not
  • [ ] Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • [ ] Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

gruberb avatar Aug 08 '24 12:08 gruberb

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.72%. Comparing base (8be45cd) to head (b3d8b83).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6340      +/-   ##
==========================================
+ Coverage   49.30%   52.72%   +3.41%     
==========================================
  Files         146      125      -21     
  Lines       13708    12820     -888     
==========================================
  Hits         6759     6759              
+ Misses       6949     6061     -888     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Aug 08 '24 12:08 codecov-commenter