Bug 1884816 - Expose icon information for suggestion as struct

[dadaa]

https://bugzilla.mozilla.org/show_bug.cgi?id=1884816

Pull Request checklist

• Breaking changes: This PR follows our breaking change policy
  • [ ] This PR follows the breaking change policy:
    • This PR has no breaking API changes, or
    • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
• [ ] Quality: This PR builds and tests run cleanly
  • Note:
    • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
    • If this pull request includes a breaking change, consider cutting a new release after merging.
• [ ] Tests: This PR includes thorough tests or an explanation of why it does not
• [ ] Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
  • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
• [ ] Dependencies: This PR follows our dependency management guidelines
  • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.09%. Comparing base (ffacc52) to head (2ed4964).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6162   +/-   ##
=======================================
  Coverage   84.09%   84.09%           
=======================================
  Files         117      117           
  Lines       15627    15627           
=======================================
  Hits        13141    13141           
  Misses       2486     2486           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[dadaa]

Thank you very much, @0c0w3 !

Naming nit: Can we use data instead of content everywhere please? data is more natural, it matches the column name in the DB, and it's shorter.

Okay!

Smaller naming nit: It would be nice to consistently use mimetype or mime_type, but no big deal I guess. It's two words, but I don't think we should change the DB schema just for that. I wonder if there's a Rust convention for one over the other?

Yeah, I also thought about the name consistency.. So, I will use mimetype for now to match with the DB scheme. Then, if we want to rename, will do it in another PR.

[dadaa]

We're going to need breaking change PRs on Android (and tests) and iOS, though. I added a section to the readme about them, but I'd be happy to walk you through the process!

@linabutler I want to confirm what to do.

1. Create a branch (e.g. application-service-pr6162) on Android side that adapts to this change.
2. Push the branch as PR to firefox-android
3. Push this PR with title including [firefox-android: application-service-pr6162]
4. Create a branch (e.g. application-service-pr6162) on iOS side that adapts to this change.
5. Push the branch as PR to firefox-ios
6. If 3 is no problem, merge this.
7. Merge iOS PR

Am I right?