agithub Examine "jp/unit tests" branch

Take a look at this branch
Figure out what it does
Decide if we want to use this
Merge it or make an issue capturing the idea or close and delete the branch

Apr 13 '18 18:04 gene1wood

@nnja Would you like to see if there's any unit test content here worth keeping?

Apr 14 '18 03:04 gene1wood

@gene1wood Sure. I'll take a look today or tomorrow.

Apr 16 '18 21:04 nnja

So, I didn't have a very good story for testing agithub. If it were me, I'd rethink this, and restart from scratch. These tests don't mock up the GitHub API (which they probably should). They require connecting to the real API, and thus require entering real credentials for any non-public API usage.

May 08 '18 14:05 jpaugh

@nnja based on @jpaugh's comment it sounds like we should remove unit tests and pursue some of the ideas you and I'd chatted about for starting from scratch on them with a good API mocking solution.

Maybe after the move from httplib to requests.

May 11 '18 23:05 gene1wood

@gene1wood @jpaugh Any chance either of you are at the PyCon 2018 sprints? I was thinking about working on this on Wednesday or for a half day on Thursday.

May 14 '18 21:05 nnja

@nnja I'm not unfortunately. If you want to call out a day and time to meet online I could video chat.

May 14 '18 21:05 gene1wood

@gene1wood Any chance you're available between 10am and 12pm EST tomorrow?

May 16 '18 02:05 nnja

@nnja Yes, ping me on keybase and we can coordinate a call.

May 16 '18 14:05 gene1wood