addons icon indicating copy to clipboard operation
addons copied to clipboard

Using middle-click or CTRL+Right-click on the extension card area opens the extension page in a new tab

Open dceban opened this issue 6 years ago • 7 comments

Steps to reproduce:

  1. Open addons.mozilla main page.
  2. Scroll to the "Featured extensions" section (or any section that has addons cards).
  3. Hover over any extension's area (but not its title).
  4. Try to open it in a new tab page using the middle click or CTRL+Click

Actual results: Extension page opened in the same tab.

Expected results: Open the extension page in a new tab.

(click where the cursor from the screenshot is located) firefoxAddonClickCard

┆Issue is synchronized with this Jira Task

dceban avatar Jun 17 '19 14:06 dceban

This appears to be due to not using a link around the block level content.

muffinresearch avatar Oct 07 '19 17:10 muffinresearch

@bobsilverberg I verified this on AMO dev with FF72(Win10).

  • using the middle click or CTRL+Click will open the add-ons in a new tab.

  • I filed https://github.com/mozilla/addons/issues/13675 which could be e regression because right now it is not reproducible on AMO stage.

new tab

ioanarusiczki avatar Feb 07 '20 13:02 ioanarusiczki

We had to back out the change that fixed this as we discovered that it created nested anchor tags. A different solution will need to be devised for this.

bobsilverberg avatar Feb 12 '20 11:02 bobsilverberg

hey @bobsilverberg i want to work again on this issue.

TheSTL avatar Feb 12 '20 12:02 TheSTL

Ok @TheSTL, go ahead. @mirefly made a suggestion about a different approach to this at https://github.com/mozilla/addons/issues/13676. I think it's going to be a bit tricky because of the recommended badge, but please feel free to give it a try.

bobsilverberg avatar Feb 12 '20 12:02 bobsilverberg

@bobsilverberg I checked on AMO stage - this doesn't look reverted to me.

AMO stage not reverted

ioanarusiczki avatar Feb 13 '20 09:02 ioanarusiczki

Old Jira Ticket: https://mozilla-hub.atlassian.net/browse/ADDFRNT-170

KevinMind avatar May 03 '24 18:05 KevinMind