addons icon indicating copy to clipboard operation
addons copied to clipboard

Theme reviewer emails not working

Open devaneymoz opened this issue 1 year ago • 3 comments

When a theme creator replies to a reviewer's approval or rejection, the reviewer is not being alerted to the response. The only way the reviewer can see a theme creator's response is if they manually go back into the review page and find a note. This is problematic for a number of scenarios, but most commonly when a reviewer may have misinterpreted a theme creator as a "spammer" and rejected their submission, but the creator responds proving they're not a spammer, yet the reviewers are receiving notifications of a response and thus often miss the communication entirely.

@diox

┆Issue is synchronized with this Jira Task

devaneymoz avatar Mar 25 '24 17:03 devaneymoz

This was a conscious decision made in https://github.com/mozilla/addons/issues/9274, because for non-themes, replies from the developer just puts the add-on back into the queue - the idea was to move away from individual notifications to reviewers, instead they would pick whatever is next in the queue whenever they are done with something. Potentially the same add-on could get reviewed by someone different next time.

At the moment theme review queue doesn't work like that though, it doesn't use the concept of "due date", and only cares about which themes are new / have new versions.

~~Maybe~~ We should resurrect the email functionality just for themes.

diox avatar Apr 02 '24 12:04 diox

Old Jira Ticket: https://mozilla-hub.atlassian.net/browse/ADDSRV-781

KevinMind avatar May 03 '24 17:05 KevinMind

@devaneymoz with the recent fixes made in https://github.com/mozilla/addons/issues/9502 we still wouldn't send an email, but when a developer replies the theme should now land back in one of the reviewer queue (depending on its status). Is that good enough?

diox avatar May 06 '24 13:05 diox

@diox That should suffice, thanks!

devaneymoz avatar May 15 '24 16:05 devaneymoz

Thanks, closing then.

diox avatar May 15 '24 16:05 diox