Spoke icon indicating copy to clipboard operation
Spoke copied to clipboard

Allow Hubs Cloud users to customize Spoke on their HC instance

Open robinkwilson opened this issue 5 years ago • 11 comments

Via a deploy script similar to deploying a custom client for hubs cloud, allow HC users to customize their spoke instance with custom code.

Relevant PRs from IEEEVR: https://github.com/MozillaReality/ieeevr-spoke/pull/1

robinkwilson avatar Jul 28 '20 18:07 robinkwilson

Hi -- are there any workarounds that would let me view a room created with a Spoke fork running locally on a Hubs Cloud deployment to interact with a custom Hubs client?

roddylindsay avatar Aug 03 '20 05:08 roddylindsay

Try this (I have not personally, so I'd love to hear how it goes. @robertlong may have more ideas too): On your Spoke fork, export the .spoke file, host the spoke file publicly (like on s3) and copy the URL. On your HC instance running the custom client, create a new room then add the custom scene (Create a scene > upper left corner hamburger menu > Choose a Scene > Custom scene > Paste .spoke file hosted URL)

If there's anything custom in the exported .spoke file, you'll need to add the way to interpret it in the custom client. Hope that helps!

robinkwilson avatar Aug 03 '20 18:08 robinkwilson

I don't think there's a great way to do this right now. I'd probably just pull in the deploy.js script from the IEEEVR fork. Then run npm run login in your Hubs client and copy your .ret.credentials file from your Hubs directory to your Spoke directory. After that you should be able to run the deploy script.

This login script is currently broken, otherwise I'd merge it into Spoke now. Perhaps I can get that fixed soon.

robertlong avatar Aug 03 '20 18:08 robertlong

@robertlong so the solution proposed by @robin-k-wilson would not work for me?

roddylindsay avatar Aug 03 '20 18:08 roddylindsay

What have you modified in your custom Spoke client? Any new objects etc?

robertlong avatar Aug 03 '20 18:08 robertlong

a new Audio Type for Video and Audio objects. Our Hubs custom client knows how to decode it.

[image: image.png]

On Mon, Aug 3, 2020 at 11:40 AM Robert Long [email protected] wrote:

What have you modified in your custom Spoke client? Any new objects etc?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mozilla/Spoke/issues/1006#issuecomment-668180060, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJWC3RLZPGSACNCM6UUAMDR64ACXANCNFSM4PKZF3YQ .

-- "Buy the ticket, take the ride."

roddylindsay avatar Aug 03 '20 18:08 roddylindsay

image

roddylindsay avatar Aug 03 '20 18:08 roddylindsay

@robertlong @robin-k-wilson any thoughts?

roddylindsay avatar Aug 07 '20 23:08 roddylindsay

@roddylindsay Why not give it a try!

@robertlong May know more about the details about hooking up new audio/video, double check that the streaming video connections in the client look familiar to dialog (our webRTC server: https://github.com/mozilla/dialog)

robinkwilson avatar Aug 09 '20 17:08 robinkwilson

Here's a request to be able to override API.js to add a search blocklist: https://github.com/mozilla/Spoke/pull/957

robertlong avatar Sep 21 '20 17:09 robertlong

hi @robinkwilson @robertlong ,

Can we deploy a custom client for Spoke to allow user customize then deploy to Spoke instances on AWS Server?

Thank you!

hungleon2112 avatar Nov 16 '21 11:11 hungleon2112