syncstorage-rs icon indicating copy to clipboard operation
syncstorage-rs copied to clipboard

Invalid value in BSOQueryParams

Open jrconlin opened this issue 4 years ago • 2 comments

An error is being generated during deserialization of the BSO Query parameters. I'm not sure which value is triggering it, but it appears to be one of the numerics.

https://sentry.prod.mozaws.net/operations/syncstorage-prod/issues/10887369/?referrer=github_plugin

ApiError: Query deserialize error: Invalid value
  File "error.rs:331", line 17, in <syncstorage::error::ApiError as core::convert::From<syncstorage::error::ApiErrorKind>>::from
  File "mod.rs:546", line 9, in <T as core::convert::Into<U>>::into
  File "error.rs:343", line 17, in <syncstorage::error::ApiError as core::convert::From<syncstorage::web::error::ValidationError>>::from
  File "mod.rs:546", line 9, in <T as core::convert::Into<U>>::into
  File "error.rs:184", line 9, in syncstorage::web::error::<impl core::convert::From<syncstorage::web::error::ValidationErrorKind> for syncstorage::error::ApiError>::from
...
(112 additional frame(s) were not displayed)

jrconlin avatar Mar 19 '21 16:03 jrconlin

Possibly from SyncTimestamp::from_header

pjenvey avatar Mar 19 '21 16:03 pjenvey

Yeah, possibly. It could be related to a bad date format or something.

To be honest, I'm starting to not be a fan of the serde habit of just puking when it hits an error, particularly when we don't have a reproduceable state. I may add an extra field for this error that shows what got fed to serde to at least help isolate some of it.

jrconlin avatar Mar 19 '21 17:03 jrconlin