mozilla-mobile
opening closing time clock icon incorrectly placed on an iPhone SE
When browsing on and iPhone SE, the clock icon for travel times overlaps the arrow for the directions.
@fluffyemily How do you think we should fix this?
I think the easiest would be to hide the clock if it overlaps the arrow. If you agree, I can check with UX.
I think the constraints are wrong. I'll take a peek & see what would fix it.
On Wed, 23 Nov 2016 at 17:01, Michael Comella [email protected] wrote:
@fluffyemily https://github.com/fluffyemily How do you think we should fix this?
I think the easiest would be to hide the clock if it overlaps the arrow. If you agree, I can check with UX.
— You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/mozilla-mobile/prox/issues/212#issuecomment-262572931, or mute the thread https://github.com/notifications/unsubscribe-auth/AMB1uBkbQx5xxKfBC4FQ5128VB9q0M6oks5rBHFogaJpZM4K2rsQ .
@antlam /@vazquez I can either shrink the text size of "Until 12:00 PM" such that the text remains central to the view and the clock icon doesn't overlap, OR I can adjust the positioning of the text such that it is off center. Which would you prefer?
Shrinking text
Offset Label
@fluffyemily When the content pushes the Clock icon beyond the container, let's just hide the Clock icon.
On a related note: the padding between the "2min walking" and the ">" in the "Offset Label" image is too big.
Also noticing that we say "No data available" under the TA reviews section there.
Let's just use "No data"
I posted this spec in issue #259 too but if we make the padding between the icons and the text 6px (like this) it should also help this issue.
With the change in copy and the 6px alignment change, I no longer see the overlap issue:
Let's reopen if it pops up again.
Can we hide the clock in these cases? it's not 100% necessary and it'll be the most elegant solution for the time being.
Can we hide the clock in these cases?
Yes, I'm currently implementing this behavior.
Backed out in #345 – the solution patch hid the ratings and the description text for unknown reasons.
Unfortunately, this is tricky to fix so I doubt we're going to fix it for the work week.