prox icon indicating copy to clipboard operation
prox copied to clipboard
verified publisher icon mozilla-mobile

Spacing of Yelp top review ICON is Off

Open vazquez opened this issue 9 years ago • 4 comments

Component: Summary Card

The spacing of the Yelp Top Review, as well as the icon size, seem to be a little bit off.

Current:

screenshot 2016-11-08 15 23 48

Expected:

screenshot 2016-11-08 15 30 08

vazquez avatar Nov 08 '16 20:11 vazquez

@vazquez What should the padding of the wikipedia icon be to the text? 8px? #11 does not specify, but mentions the wikipedia icon is 16x16.

mcomella avatar Nov 09 '16 22:11 mcomella

@mcomella – 8px

screenshot 2016-11-09 17 55 11

vazquez avatar Nov 09 '16 22:11 vazquez

@antlam @vazquez Emily modified how this works – is this still an issue?

It may be hard to fix for the Sprint, given the special casing code.

mcomella avatar Nov 30 '16 17:11 mcomella

We should be giving same sized icons anyways. Let's fix this after Kona.

antlam avatar Nov 30 '16 17:11 antlam