focus-android icon indicating copy to clipboard operation
focus-android copied to clipboard

~46ms regression to COLD VIEW nav start (Sentry SDK?)

Open mcomella opened this issue 4 years ago • 8 comments

On 3/10, we see a regression of about ~46ms from our weekly backfill (that I don't think we see in fenix): image

Let's find the cause. You can use backfill.py to bisect the commit that caused the issue – let me know if you have questions.

mcomella avatar Mar 14 '22 19:03 mcomella

Triage: jonalmeida suggested we landed the Sentry SDK on that day so that's probably what changed.

mcomella avatar Mar 16 '22 20:03 mcomella

Triage: Jonalmeida said they'd do a manual bisection.

mcomella avatar Mar 16 '22 20:03 mcomella

We're seeing a trend upwards in both VIEW and MAIN: it's unclear if it's related to Sentry or another regression. Since there's no clear point of "regression", I'm going to leave the investigation as part of this bug. image

mcomella avatar Mar 21 '22 19:03 mcomella

Using backfill.py I measured for Focus Nightly the cold start up duration(cold_view_nav_start) before and after this pr As you can see the median values are pretty similar(19ms)

Results for 03.09.2022 vs 03.08.2022

Screenshot 2022-05-25 at 15 00 17

On the other hand I noticed a considerable difference after this pr I will take a look in AC to see what changes were made in that update

Results for 03.10.2022

Screenshot 2022-05-25 at 15 33 29

ionutbedregeanu avatar May 25 '22 12:05 ionutbedregeanu

@jonalmeida @mcomella After some investigation made with git bisect in AC I noticed a regression after this change

Before gecko update

Screenshot 2022-05-27 at 14 23 57

With gecko update

Screenshot 2022-05-27 at 14 24 34

ionutbedregeanu avatar May 27 '22 11:05 ionutbedregeanu

@jonalmeida I don't have the setup for going lower in geckoview and trying to find there the regression. Should I open a ticket on Bugzilla?

ionutbedregeanu avatar May 27 '22 11:05 ionutbedregeanu

If you wanted to continue debugging, you can take a profile before the change and after the change and compare to see what's different. Since the Firefox Profiler doesn't start profiling that early during start up, you may want to capture the profile using the Debug API. Since the change is small, however, it might be hard to spot. fwiw, if you share the profiles or identify the cause, that could make the bug more actionable for the folks working on geckoview when you file that Bugzilla ticket.

mcomella avatar May 27 '22 23:05 mcomella

Unfortunately I don't have a device with an android version < 11 and I can't set the permissions to capture the profile using the Debug API I tried with emulators also but I didn't succeed I will unassign this from me, maybe someone else can help

ionutbedregeanu avatar Jun 02 '22 13:06 ionutbedregeanu

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1802645

Change performed by the Move to Bugzilla add-on.

cpeterso avatar Nov 26 '22 05:11 cpeterso