android-components icon indicating copy to clipboard operation
android-components copied to clipboard

Fix gradle version code generation on Windows

Open fice-t opened this issue 3 years ago • 0 comments

Building on Windows with the git config core.autocrlf=true (sorry) results in a line ending of \r\n in version.txt, so just removing \n leaves trailing whitespace in the resulting Java code that ends in a build failure.

Testing for this perhaps could be included in future Windows-specific CI.

Pull Request checklist

  • [x] Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • [x] Tests: This PR includes thorough tests or an explanation of why it does not
  • [x] Changelog: This PR includes a changelog entry or does not need one
  • [x] Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

GitHub Automation

fice-t avatar Sep 23 '22 17:09 fice-t