android-components icon indicating copy to clipboard operation
android-components copied to clipboard
verified publisher icon mozilla-mobile

For #12500: Update navigation, lifecycle, core and fragment dependencies.

Open mcarare opened this issue 3 years ago • 5 comments

Pull Request checklist

  • [x] Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • [x] Tests: This PR includes thorough tests or an explanation of why it does not
  • [ ] Changelog: This PR includes a changelog entry or does not need one
  • [x] Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

GitHub Automation

Fixes #12500

mcarare avatar Jul 14 '22 15:07 mcarare

bors try

Amejia481 avatar Aug 10 '22 14:08 Amejia481

Looks like there are some breaking changes that we will need to address on Fenix and Focus.

Fenix

e: /fenix/app/src/main/java/org/mozilla/fenix/browser/SwipeGestureLayout.kt: (116, 50): Type mismatch: inferred type is MotionEvent? but MotionEvent was expected
e: /fenix/app/src/main/java/org/mozilla/fenix/browser/SwipeGestureLayout.kt: (133, 50): Type mismatch: inferred type is MotionEvent? but MotionEvent was expected
e: /fenix/app/src/main/java/org/mozilla/fenix/components/StoreProvider.kt: (36, 7): Inheritance from an interface with '@JvmDefault' members is only allowed with -Xjvm-default option
e: /fenix/app/src/main/java/org/mozilla/fenix/compose/ComposeViewHolder.kt: (14, 28): Unresolved reference: ViewTreeSavedStateRegistryOwner
e: /fenix/app/src/main/java/org/mozilla/fenix/compose/ComposeViewHolder.kt: (51, 9): Unresolved reference: ViewTreeSavedStateRegistryOwner
e: /fenix/app/src/main/java/org/mozilla/fenix/compose/cfr/CFRPopupFullscreenLayout.kt: (32, 28): Unresolved reference: ViewTreeSavedStateRegistryOwner
e: /fenix/app/src/main/java/org/mozilla/fenix/compose/cfr/CFRPopupFullscreenLayout.kt: (106, 9): Unresolved reference: ViewTreeSavedStateRegistryOwner
e: /fenix/app/src/main/java/org/mozilla/fenix/compose/cfr/CFRPopupFullscreenLayout.kt: (106, 51): Unresolved reference: ViewTreeSavedStateRegistryOwner
e: /fenix/app/src/main/java/org/mozilla/fenix/compose/cfr/CFRPopupFullscreenLayout.kt: (313, 9): Unresolved reference: ViewTreeSavedStateRegistryOwner
e: /fenix/app/src/main/java/org/mozilla/fenix/tabstray/browser/compose/ComposeAbstractTabViewHolder.kt: (13, 28): Unresolved reference: ViewTreeSavedStateRegistryOwner
e: /fenix/app/src/main/java/org/mozilla/fenix/tabstray/browser/compose/ComposeAbstractTabViewHolder.kt: (48, 9): Unresolved reference: ViewTreeSavedStateRegistryOwner
e: /fenix/app/src/main/java/org/mozilla/fenix/trackingprotection/TrackingProtectionPanelView.kt: (284, 17): 'onInitializeAccessibilityNodeInfo' overrides nothing
e: /fenix/app/src/main/java/org/mozilla/fenix/trackingprotection/TrackingProtectionPanelView.kt: (289, 61): Type mismatch: inferred type is View? but View was expected

Focus

e: /focus-android/app/src/main/java/org/mozilla/focus/compose/CFRPopup.kt: (53, 28): Unresolved reference: ViewTreeSavedStateRegistryOwner
e: /focus-android/app/src/main/java/org/mozilla/focus/compose/CFRPopup.kt: (191, 9): Unresolved reference: ViewTreeSavedStateRegistryOwner
e: /focus-android/app/src/main/java/org/mozilla/focus/compose/CFRPopup.kt: (191, 51): Unresolved reference: ViewTreeSavedStateRegistryOwner
e: /focus-android/app/src/main/java/org/mozilla/focus/compose/CFRPopup.kt: (373, 9): Unresolved reference: ViewTreeSavedStateRegistryOwner

Amejia481 avatar Aug 10 '22 15:08 Amejia481

bors try

Amejia481 avatar Aug 10 '22 15:08 Amejia481

try

Already running a review

bors[bot] avatar Aug 10 '22 15:08 bors[bot]

My bad now I see there are already PRs on Fenix https://github.com/mozilla-mobile/fenix/pull/25991/ and Focus https://github.com/mozilla-mobile/focus-android/pull/7379

Amejia481 avatar Aug 10 '22 17:08 Amejia481

It looks like there are a couple of tests that we need to still address :)

``` [task 2022-08-17T10:38:22.384Z] SUITE: mozilla.components.feature.search.widget.BaseVoiceSearchActivityTest [task 2022-08-17T10:38:22.484Z] TEST: process intent with speech processing set to false [task 2022-08-17T10:38:22.784Z] D/LifecycleMonitor: Lifecycle status change: mozilla.components.feature.search.widget.BaseVoiceSearchActivityExtendedForTests@5a42418f in: PRE_ON_CREATE [task 2022-08-17T10:38:22.984Z] FAILURE [task 2022-08-17T10:38:22.984Z] [task 2022-08-17T10:38:22.985Z] java.lang.IllegalStateException: You need to use a Theme.AppCompat theme (or descendant) with this activity. [task 2022-08-17T10:38:22.985Z] at androidx.appcompat.app.AppCompatDelegateImpl.createSubDecor(AppCompatDelegateImpl.java:846) [task 2022-08-17T10:38:22.985Z] at androidx.appcompat.app.AppCompatDelegateImpl.ensureSubDecor(AppCompatDelegateImpl.java:809) [task 2022-08-17T10:38:22.985Z] at androidx.appcompat.app.AppCompatDelegateImpl.initWindowDecorActionBar(AppCompatDelegateImpl.java:550) [task 2022-08-17T10:38:22.985Z] at androidx.appcompat.app.AppCompatDelegateImpl.getSupportActionBar(AppCompatDelegateImpl.java:537) [task 2022-08-17T10:38:22.986Z] at androidx.appcompat.app.AppCompatDelegateImpl.invalidateOptionsMenu(AppCompatDelegateImpl.java:1220) [task 2022-08-17T10:38:22.986Z] at androidx.appcompat.app.AppCompatActivity.invalidateOptionsMenu(AppCompatActivity.java:314) [task 2022-08-17T10:38:22.986Z] at androidx.activity.ComponentActivity.invalidateMenu(ComponentActivity.java:553) [task 2022-08-17T10:38:22.986Z] at androidx.core.view.MenuHostHelper.addMenuProvider(MenuHostHelper.java:116) [task 2022-08-17T10:38:22.986Z] at androidx.activity.ComponentActivity.addMenuProvider(ComponentActivity.java:531) [task 2022-08-17T10:38:22.986Z] at androidx.fragment.app.FragmentActivity$HostCallbacks.addMenuProvider(FragmentActivity.java:736) [task 2022-08-17T10:38:22.986Z] at androidx.fragment.app.FragmentManager.attachController(FragmentManager.java:2784) [task 2022-08-17T10:38:22.987Z] at androidx.fragment.app.FragmentController.attachHost(FragmentController.java:117) [task 2022-08-17T10:38:22.987Z] at androidx.fragment.app.FragmentActivity.lambda$init$3(FragmentActivity.java:140) [task 2022-08-17T10:38:22.987Z] at androidx.activity.contextaware.ContextAwareHelper.dispatchOnContextAvailable(ContextAwareHelper.java:99) [task 2022-08-17T10:38:22.987Z] at androidx.activity.ComponentActivity.onCreate(ComponentActivity.java:352) [task 2022-08-17T10:38:22.987Z] at androidx.fragment.app.FragmentActivity.onCreate(FragmentActivity.java:217) [task 2022-08-17T10:38:22.987Z] at mozilla.components.feature.search.widget.BaseVoiceSearchActivity.onCreate(BaseVoiceSearchActivity.kt:39) [task 2022-08-17T10:38:22.987Z] at android.app.Activity.performCreate(Activity.java:7136) [task 2022-08-17T10:38:22.987Z] at android.app.Activity.performCreate(Activity.java:7127) [task 2022-08-17T10:38:22.987Z] at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1271) [task 2022-08-17T10:38:22.987Z] at org.robolectric.android.internal.RoboMonitoringInstrumentation.callActivityOnCreate(RoboMonitoringInstrumentation.java:279) [task 2022-08-17T10:38:22.987Z] at org.robolectric.android.controller.ActivityController.lambda$create$0(ActivityController.java:130) [task 2022-08-17T10:38:22.987Z] at org.robolectric.shadows.ShadowPausedLooper.runPaused(ShadowPausedLooper.java:204) [task 2022-08-17T10:38:22.987Z] at org.robolectric.android.controller.ActivityController.create(ActivityController.java:128) [task 2022-08-17T10:38:22.987Z] at org.robolectric.android.controller.ActivityController.create(ActivityController.java:137) [task 2022-08-17T10:38:22.987Z] at mozilla.components.feature.search.widget.BaseVoiceSearchActivityTest.process intent with speech processing set to false(BaseVoiceSearchActivityTest.kt:78) [task 2022-08-17T10:38:22.987Z] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [task 2022-08-17T10:38:22.987Z] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) [task 2022-08-17T10:38:22.987Z] at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [task 2022-08-17T10:38:22.987Z] at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) [task 2022-08-17T10:38:22.987Z] at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) [task 2022-08-17T10:38:22.987Z] at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) [task 2022-08-17T10:38:22.987Z] at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) [task 2022-08-17T10:38:22.987Z] at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) [task 2022-08-17T10:38:22.987Z] at org.robolectric.RobolectricTestRunner$HelperTestRunner$1.evaluate(RobolectricTestRunner.java:591) [task 2022-08-17T10:38:22.987Z] at org.robolectric.internal.SandboxTestRunner$2.lambda$evaluate$0(SandboxTestRunner.java:274) [task 2022-08-17T10:38:22.987Z] at org.robolectric.internal.bytecode.Sandbox.lambda$runOnMainThread$0(Sandbox.java:88) [task 2022-08-17T10:38:22.987Z] at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) [task 2022-08-17T10:38:22.987Z] at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [task 2022-08-17T10:38:22.987Z] at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [task 2022-08-17T10:38:22.987Z] at java.base/java.lang.Thread.run(Thread.java:829) [task 2022-08-17T10:38:22.987Z] [task 2022-08-17T10:38:22.987Z] TEST: handle invalid result code [task 2022-08-17T10:38:22.987Z] SUCCESS [task 2022-08-17T10:38:22.987Z] [task 2022-08-17T10:38:22.987Z] TEST: save previous intent to instance state [task 2022-08-17T10:38:22.987Z] D/LifecycleMonitor: Lifecycle status change: mozilla.components.feature.search.widget.BaseVoiceSearchActivityExtendedForTests@3034dba2 in: PRE_ON_CREATE [task 2022-08-17T10:38:22.987Z] FAILURE [task 2022-08-17T10:38:22.987Z] [task 2022-08-17T10:38:22.989Z] java.lang.IllegalStateException: You need to use a Theme.AppCompat theme (or descendant) with this activity. [task 2022-08-17T10:38:22.989Z] at androidx.appcompat.app.AppCompatDelegateImpl.createSubDecor(AppCompatDelegateImpl.java:846) [task 2022-08-17T10:38:22.989Z] at androidx.appcompat.app.AppCompatDelegateImpl.ensureSubDecor(AppCompatDelegateImpl.java:809) [task 2022-08-17T10:38:22.989Z] at androidx.appcompat.app.AppCompatDelegateImpl.initWindowDecorActionBar(AppCompatDelegateImpl.java:550) [task 2022-08-17T10:38:22.989Z] at androidx.appcompat.app.AppCompatDelegateImpl.getSupportActionBar(AppCompatDelegateImpl.java:537) [task 2022-08-17T10:38:22.989Z] at androidx.appcompat.app.AppCompatDelegateImpl.invalidateOptionsMenu(AppCompatDelegateImpl.java:1220) [task 2022-08-17T10:38:22.989Z] at androidx.appcompat.app.AppCompatActivity.invalidateOptionsMenu(AppCompatActivity.java:314) [task 2022-08-17T10:38:22.989Z] at androidx.activity.ComponentActivity.invalidateMenu(ComponentActivity.java:553) [task 2022-08-17T10:38:22.989Z] at androidx.core.view.MenuHostHelper.addMenuProvider(MenuHostHelper.java:116) [task 2022-08-17T10:38:22.989Z] at androidx.activity.ComponentActivity.addMenuProvider(ComponentActivity.java:531) [task 2022-08-17T10:38:22.989Z] at androidx.fragment.app.FragmentActivity$HostCallbacks.addMenuProvider(FragmentActivity.java:736) [task 2022-08-17T10:38:22.989Z] at androidx.fragment.app.FragmentManager.attachController(FragmentManager.java:2784) [task 2022-08-17T10:38:22.989Z] at androidx.fragment.app.FragmentController.attachHost(FragmentController.java:117) [task 2022-08-17T10:38:22.989Z] at androidx.fragment.app.FragmentActivity.lambda$init$3(FragmentActivity.java:140) [task 2022-08-17T10:38:22.989Z] at androidx.activity.contextaware.ContextAwareHelper.dispatchOnContextAvailable(ContextAwareHelper.java:99) [task 2022-08-17T10:38:22.989Z] at androidx.activity.ComponentActivity.onCreate(ComponentActivity.java:352) [task 2022-08-17T10:38:22.989Z] at androidx.fragment.app.FragmentActivity.onCreate(FragmentActivity.java:217) [task 2022-08-17T10:38:22.990Z] at mozilla.components.feature.search.widget.BaseVoiceSearchActivity.onCreate(BaseVoiceSearchActivity.kt:39) [task 2022-08-17T10:38:22.990Z] at android.app.Activity.performCreate(Activity.java:7136) [task 2022-08-17T10:38:22.990Z] at android.app.Activity.performCreate(Activity.java:7127) [task 2022-08-17T10:38:22.990Z] at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1271) [task 2022-08-17T10:38:22.990Z] at org.robolectric.android.internal.RoboMonitoringInstrumentation.callActivityOnCreate(RoboMonitoringInstrumentation.java:279) [task 2022-08-17T10:38:22.990Z] at org.robolectric.android.controller.ActivityController.lambda$create$0(ActivityController.java:130) [task 2022-08-17T10:38:22.990Z] at org.robolectric.shadows.ShadowPausedLooper.runPaused(ShadowPausedLooper.java:204) [task 2022-08-17T10:38:22.990Z] at org.robolectric.android.controller.ActivityController.create(ActivityController.java:128) [task 2022-08-17T10:38:22.990Z] at mozilla.components.feature.search.widget.BaseVoiceSearchActivityTest.save previous intent to instance state(BaseVoiceSearchActivityTest.kt:105) [task 2022-08-17T10:38:22.990Z] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [task 2022-08-17T10:38:22.990Z] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) [task 2022-08-17T10:38:22.990Z] at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [task 2022-08-17T10:38:22.990Z] at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) [task 2022-08-17T10:38:22.990Z] at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) [task 2022-08-17T10:38:22.991Z] at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) [task 2022-08-17T10:38:22.991Z] at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) [task 2022-08-17T10:38:22.991Z] at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) [task 2022-08-17T10:38:22.991Z] at org.robolectric.RobolectricTestRunner$HelperTestRunner$1.evaluate(RobolectricTestRunner.java:591) [task 2022-08-17T10:38:22.991Z] at org.robolectric.internal.SandboxTestRunner$2.lambda$evaluate$0(SandboxTestRunner.java:274) [task 2022-08-17T10:38:22.991Z] at org.robolectric.internal.bytecode.Sandbox.lambda$runOnMainThread$0(Sandbox.java:88) [task 2022-08-17T10:38:22.991Z] at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) [task 2022-08-17T10:38:22.991Z] at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [task 2022-08-17T10:38:22.991Z] at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [task 2022-08-17T10:38:22.991Z] at java.base/java.lang.Thread.run(Thread.java:829) [task 2022-08-17T10:38:22.992Z] [task 2022-08-17T10:38:22.992Z] TEST: process null intent [task 2022-08-17T10:38:22.992Z] D/LifecycleMonitor: Lifecycle status change: mozilla.components.feature.search.widget.BaseVoiceSearchActivityExtendedForTests@8e7b7df in: PRE_ON_CREATE [task 2022-08-17T10:38:22.992Z] FAILURE [task 2022-08-17T10:38:23.084Z] [task 2022-08-17T10:38:23.084Z] java.lang.IllegalStateException: You need to use a Theme.AppCompat theme (or descendant) with this activity. [task 2022-08-17T10:38:23.084Z] at androidx.appcompat.app.AppCompatDelegateImpl.createSubDecor(AppCompatDelegateImpl.java:846) [task 2022-08-17T10:38:23.084Z] at androidx.appcompat.app.AppCompatDelegateImpl.ensureSubDecor(AppCompatDelegateImpl.java:809) [task 2022-08-17T10:38:23.084Z] at androidx.appcompat.app.AppCompatDelegateImpl.initWindowDecorActionBar(AppCompatDelegateImpl.java:550) [task 2022-08-17T10:38:23.085Z] at androidx.appcompat.app.AppCompatDelegateImpl.getSupportActionBar(AppCompatDelegateImpl.java:537) [task 2022-08-17T10:38:23.085Z] at androidx.appcompat.app.AppCompatDelegateImpl.invalidateOptionsMenu(AppCompatDelegateImpl.java:1220) [task 2022-08-17T10:38:23.085Z] at androidx.appcompat.app.AppCompatActivity.invalidateOptionsMenu(AppCompatActivity.java:314) [task 2022-08-17T10:38:23.085Z] at androidx.activity.ComponentActivity.invalidateMenu(ComponentActivity.java:553) [task 2022-08-17T10:38:23.085Z] at androidx.core.view.MenuHostHelper.addMenuProvider(MenuHostHelper.java:116) [task 2022-08-17T10:38:23.085Z] at androidx.activity.ComponentActivity.addMenuProvider(ComponentActivity.java:531) [task 2022-08-17T10:38:23.085Z] at androidx.fragment.app.FragmentActivity$HostCallbacks.addMenuProvider(FragmentActivity.java:736) [task 2022-08-17T10:38:23.085Z] at androidx.fragment.app.FragmentManager.attachController(FragmentManager.java:2784) [task 2022-08-17T10:38:23.085Z] at androidx.fragment.app.FragmentController.attachHost(FragmentController.java:117) [task 2022-08-17T10:38:23.085Z] at androidx.fragment.app.FragmentActivity.lambda$init$3(FragmentActivity.java:140) [task 2022-08-17T10:38:23.085Z] at androidx.activity.contextaware.ContextAwareHelper.dispatchOnContextAvailable(ContextAwareHelper.java:99) [task 2022-08-17T10:38:23.086Z] at androidx.activity.ComponentActivity.onCreate(ComponentActivity.java:352) [task 2022-08-17T10:38:23.086Z] at androidx.fragment.app.FragmentActivity.onCreate(FragmentActivity.java:217) [task 2022-08-17T10:38:23.086Z] at mozilla.components.feature.search.widget.BaseVoiceSearchActivity.onCreate(BaseVoiceSearchActivity.kt:39) [task 2022-08-17T10:38:23.086Z] at android.app.Activity.performCreate(Activity.java:7136) [task 2022-08-17T10:38:23.086Z] at android.app.Activity.performCreate(Activity.java:7127) [task 2022-08-17T10:38:23.086Z] at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1271) [task 2022-08-17T10:38:23.087Z] at org.robolectric.android.internal.RoboMonitoringInstrumentation.callActivityOnCreate(RoboMonitoringInstrumentation.java:279) [task 2022-08-17T10:38:23.087Z] at org.robolectric.android.controller.ActivityController.lambda$create$0(ActivityController.java:130) [task 2022-08-17T10:38:23.087Z] at org.robolectric.shadows.ShadowPausedLooper.runPaused(ShadowPausedLooper.java:204) [task 2022-08-17T10:38:23.087Z] at org.robolectric.android.controller.ActivityController.create(ActivityController.java:128) [task 2022-08-17T10:38:23.087Z] at org.robolectric.android.controller.ActivityController.create(ActivityController.java:137) [task 2022-08-17T10:38:23.087Z] at mozilla.components.feature.search.widget.BaseVoiceSearchActivityTest.process null intent(BaseVoiceSearchActivityTest.kt:89) [task 2022-08-17T10:38:23.087Z] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [task 2022-08-17T10:38:23.087Z] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) [task 2022-08-17T10:38:23.087Z] at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [task 2022-08-17T10:38:23.087Z] at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) [task 2022-08-17T10:38:23.088Z] at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) [task 2022-08-17T10:38:23.088Z] at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) [task 2022-08-17T10:38:23.088Z] at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) [task 2022-08-17T10:38:23.088Z] at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) [task 2022-08-17T10:38:23.088Z] at org.robolectric.RobolectricTestRunner$HelperTestRunner$1.evaluate(RobolectricTestRunner.java:591) [task 2022-08-17T10:38:23.088Z] at org.robolectric.internal.SandboxTestRunner$2.lambda$evaluate$0(SandboxTestRunner.java:274) [task 2022-08-17T10:38:23.088Z] at org.robolectric.internal.bytecode.Sandbox.lambda$runOnMainThread$0(Sandbox.java:88) [task 2022-08-17T10:38:23.088Z] at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) [task 2022-08-17T10:38:23.088Z] at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [task 2022-08-17T10:38:23.088Z] at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [task 2022-08-17T10:38:23.088Z] at java.base/java.lang.Thread.run(Thread.java:829) [task 2022-08-17T10:38:23.089Z] [task 2022-08-17T10:38:23.089Z] TEST: process intent with speech processing set to true [task 2022-08-17T10:38:23.089Z] SUCCESS [task 2022-08-17T10:38:23.089Z] [task 2022-08-17T10:38:23.089Z] TEST: process intent with speech processing in previous intent set to true [task 2022-08-17T10:38:23.089Z] D/LifecycleMonitor: Lifecycle status change: mozilla.components.feature.search.widget.BaseVoiceSearchActivityExtendedForTests@64b0e1db in: PRE_ON_CREATE [task 2022-08-17T10:38:23.089Z] FAILURE [task 2022-08-17T10:38:23.089Z] [task 2022-08-17T10:38:23.089Z] java.lang.IllegalStateException: You need to use a Theme.AppCompat theme (or descendant) with this activity. [task 2022-08-17T10:38:23.089Z] at androidx.appcompat.app.AppCompatDelegateImpl.createSubDecor(AppCompatDelegateImpl.java:846) [task 2022-08-17T10:38:23.089Z] at androidx.appcompat.app.AppCompatDelegateImpl.ensureSubDecor(AppCompatDelegateImpl.java:809) [task 2022-08-17T10:38:23.089Z] at androidx.appcompat.app.AppCompatDelegateImpl.initWindowDecorActionBar(AppCompatDelegateImpl.java:550) [task 2022-08-17T10:38:23.089Z] at androidx.appcompat.app.AppCompatDelegateImpl.getSupportActionBar(AppCompatDelegateImpl.java:537) [task 2022-08-17T10:38:23.089Z] at androidx.appcompat.app.AppCompatDelegateImpl.invalidateOptionsMenu(AppCompatDelegateImpl.java:1220) [task 2022-08-17T10:38:23.089Z] at androidx.appcompat.app.AppCompatActivity.invalidateOptionsMenu(AppCompatActivity.java:314) [task 2022-08-17T10:38:23.090Z] at androidx.activity.ComponentActivity.invalidateMenu(ComponentActivity.java:553) [task 2022-08-17T10:38:23.090Z] at androidx.core.view.MenuHostHelper.addMenuProvider(MenuHostHelper.java:116) [task 2022-08-17T10:38:23.090Z] at androidx.activity.ComponentActivity.addMenuProvider(ComponentActivity.java:531) [task 2022-08-17T10:38:23.090Z] at androidx.fragment.app.FragmentActivity$HostCallbacks.addMenuProvider(FragmentActivity.java:736) [task 2022-08-17T10:38:23.090Z] at androidx.fragment.app.FragmentManager.attachController(FragmentManager.java:2784) [task 2022-08-17T10:38:23.090Z] at androidx.fragment.app.FragmentController.attachHost(FragmentController.java:117) [task 2022-08-17T10:38:23.090Z] at androidx.fragment.app.FragmentActivity.lambda$init$3(FragmentActivity.java:140) [task 2022-08-17T10:38:23.091Z] at androidx.activity.contextaware.ContextAwareHelper.dispatchOnContextAvailable(ContextAwareHelper.java:99) [task 2022-08-17T10:38:23.091Z] at androidx.activity.ComponentActivity.onCreate(ComponentActivity.java:352) [task 2022-08-17T10:38:23.091Z] at androidx.fragment.app.FragmentActivity.onCreate(FragmentActivity.java:217) [task 2022-08-17T10:38:23.091Z] at mozilla.components.feature.search.widget.BaseVoiceSearchActivity.onCreate(BaseVoiceSearchActivity.kt:39) [task 2022-08-17T10:38:23.091Z] at android.app.Activity.performCreate(Activity.java:7136) [task 2022-08-17T10:38:23.092Z] at android.app.Activity.performCreate(Activity.java:7127) [task 2022-08-17T10:38:23.092Z] at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1271) [task 2022-08-17T10:38:23.092Z] at org.robolectric.android.internal.RoboMonitoringInstrumentation.callActivityOnCreate(RoboMonitoringInstrumentation.java:279) [task 2022-08-17T10:38:23.092Z] at org.robolectric.android.controller.ActivityController.lambda$create$0(ActivityController.java:130) [task 2022-08-17T10:38:23.092Z] at org.robolectric.shadows.ShadowPausedLooper.runPaused(ShadowPausedLooper.java:204) [task 2022-08-17T10:38:23.093Z] at org.robolectric.android.controller.ActivityController.create(ActivityController.java:128) [task 2022-08-17T10:38:23.093Z] at mozilla.components.feature.search.widget.BaseVoiceSearchActivityTest.process intent with speech processing in previous intent set to true(BaseVoiceSearchActivityTest.kt:120) [task 2022-08-17T10:38:23.093Z] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [task 2022-08-17T10:38:23.093Z] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) [task 2022-08-17T10:38:23.093Z] at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [task 2022-08-17T10:38:23.093Z] at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) [task 2022-08-17T10:38:23.094Z] at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) [task 2022-08-17T10:38:23.094Z] at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) [task 2022-08-17T10:38:23.094Z] at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) [task 2022-08-17T10:38:23.094Z] at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) [task 2022-08-17T10:38:23.094Z] at org.robolectric.RobolectricTestRunner$HelperTestRunner$1.evaluate(RobolectricTestRunner.java:591) [task 2022-08-17T10:38:23.094Z] at org.robolectric.internal.SandboxTestRunner$2.lambda$evaluate$0(SandboxTestRunner.java:274) [task 2022-08-17T10:38:23.095Z] at org.robolectric.internal.bytecode.Sandbox.lambda$runOnMainThread$0(Sandbox.java:88) [task 2022-08-17T10:38:23.095Z] at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) [task 2022-08-17T10:38:23.095Z] at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [task 2022-08-17T10:38:23.095Z] at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [task 2022-08-17T10:38:23.095Z] at java.base/java.lang.Thread.run(Thread.java:829) [task 2022-08-17T10:38:23.095Z] [task 2022-08-17T10:38:23.484Z] [task 2022-08-17T10:38:23.484Z] 319 tests completed, 4 failed, 1 skipped ```

Amejia481 avatar Aug 22 '22 00:08 Amejia481

bors try

Amejia481 avatar Aug 22 '22 00:08 Amejia481

try

Already running a review

bors[bot] avatar Aug 22 '22 00:08 bors[bot]

It looks like there are a couple of tests that we need to still address :)

Yes, These were added recently, I will get to them. :)

mcarare avatar Aug 22 '22 07:08 mcarare

try

Build failed:

bors[bot] avatar Aug 26 '22 19:08 bors[bot]

Tested this against the Fenix PR and also against Focus main (https://github.com/mozilla-mobile/focus-android/commit/309ef347cfff806758d17fa19eba71f6c0cb23ea)

jonalmeida avatar Oct 08 '22 00:10 jonalmeida