lockbox-extension icon indicating copy to clipboard operation
lockbox-extension copied to clipboard

Interaction design to fill saved credentials that enables user involvement without impeding efficiency

Open sandysage opened this issue 8 years ago • 14 comments

First story coming from the epic #467 to provide user control over what gets populated and where. This requires a new design as "fill" won't happen automatically to start.

Acceptance criteria

  • Design should allow the user to have control over what gets populated
  • Design should be oriented around efficiency where a user can fill a web form in 3 clicks or less
  • Design should have a clear backup option for copy/paste for when fill doesn't work

sandysage avatar Jan 25 '18 17:01 sandysage

Based on the conversation yesterday between @jimporter, @linuxwolf, and myself, we'll plan on moving forward with the following exploration...

  • Contextual form field callouts on username/password fields of a given website
  • Tapping on the callout would present an overlay displaying any matching entries associated with the URL
  • Fill actions can be accessed from both the username and the password fields, and one callout action will fill both fields (ideally)
  • The state of the icon in the toolbar may require exploration for both status (authenticated or not), number of entries matching a current page, and successful fill (trust that the overlay is coming from lockbox extension, and not a phising attack)

changecourse avatar Feb 01 '18 20:02 changecourse

Adding needs-pi in the event we'd like an a11y review by @kimberlythegeek

m8ttyB avatar Feb 01 '18 23:02 m8ttyB

Initial designs included below, which represent the bullet points for our tentative acceptance criteria of this new feature...

login fill - 0 0 login fill - 1 0 login fill - 2 0

Ready for review.

changecourse avatar Feb 06 '18 21:02 changecourse

Initial accessibility review complete. These designs look fine. Once we have have a working mock, we will do a complete Accessibility review.

kimberlythegeek avatar Feb 06 '18 21:02 kimberlythegeek

Based on feedback from @linuxwolf on today's call, I've made the following tweaks...

  • updated toolbar icon that has a more accessibility-friendly indication of matching entries (dot notification instead of color change)
  • revised icon color to correspond with toolbar indicator
  • removal of check mark affordance (we'll maintain the same icon state for pre-filled vs. filled actions)

login fill - 0 0 login fill - 1 0 login fill - 2 0

changecourse avatar Feb 12 '18 23:02 changecourse

Handling multiple matching entries:

login fill - two entries login fill - more than two entries

changecourse avatar Feb 12 '18 23:02 changecourse

(regarding multiple matches) @changecourse something to keep in mind, although I don't know if/when it'll be an actual problem:

an overlay would have to be "in content", which means it is theoretically possible for a portion to be outside the viewport (visible boundaries of the content window). Using a separate popup window carries even more baggage AFAICT.

linuxwolf avatar Feb 13 '18 16:02 linuxwolf

@linuxwolf understood, though in most of the use cases I've explored (auditing common login forms on websites for top sites) I feel that having an overlay that extends below and to the left being the best case scenario for the vast majority of login forms.

changecourse avatar Feb 14 '18 18:02 changecourse

@changecourse I agree it's an edge case, and a very thin edge at that. This will need to be taken into account by @mozilla-lockbox/product-integrity and testing as a known risk.

linuxwolf avatar Feb 14 '18 20:02 linuxwolf

@linuxwolf can I take this as a thinly veiled acceptance of the designs then? 😛

If yes, feel free to pull the 'needs-eng' tag

changecourse avatar Feb 14 '18 20:02 changecourse

@changecourse 👍

linuxwolf avatar Feb 14 '18 20:02 linuxwolf

Per discussion with @changecourse:

  1. The icon only appears when there is an entry that matches the URI AND we can detect both the username and password fields. We realize this means that there will be cases where fill doesn't appear at all and users will need to use the doorhanger UI to copy/paste. @linuxwolf do you have a rough estimate for how often this will/won't work given this "and" parameter?
  2. "Edit" is intended to take the user to the management tab UI to that entry. That is not currently implemented, but a story to capture that was created in #355. I would propose we continue to build the requirements for edit in #355 and proceed with scoping this fill work without the 'edit' option. This is just to split the work.

sandysage avatar Feb 20 '18 20:02 sandysage

Remaining open to break out into engineering stories. Need @jimporter to help identify the work to implement.

sandysage avatar Feb 21 '18 22:02 sandysage

Per my chat with @jimporter today, we're going to work on scoping this effort in #625. Leaving this open as I would expect some amount of design refinements needed or at least some final agreement that this works as designed. @changecourse let me know if you feel otherwise.

sandysage avatar Mar 08 '18 00:03 sandysage