move icon indicating copy to clipboard operation
move copied to clipboard

[Feature Request] Make a note in setup for SOLC_EXE for solidity tests

Open gregnazario opened this issue 3 years ago • 1 comments

🚀 Feature Request

Make a note in setup for SOLC_EXE for solidity tests

Motivation

Is your feature request related to a problem? Please describe. I was getting really confused why it was always telling me SOLC_EXE couldn't be found, then I realized you needed the solidity compiler for some compatibility tests. It's a little weird, and just would be great to call out / make these tests run separately when I just do cargo test.

If I missed where this is mentioned in the docs lmk.

gregnazario avatar Apr 14 '22 16:04 gregnazario

Like for the prover, if the right tool is not found (i.e. SOLC_EXE is undefined), we should have a graceful error message pointing to hat dev_setup,sh -dp should be run. We could also check for the version, as we do e.g. here for the prover:

https://github.com/move-language/move/blob/main/language/move-prover/boogie-backend/src/options.rs#L253

wrwg avatar Apr 14 '22 17:04 wrwg