core icon indicating copy to clipboard operation
core copied to clipboard

remove deprecated inline eslint directives

Open nikoskalogridis opened this issue 7 years ago • 4 comments

sorry for missing them out on the previous PR

nikoskalogridis avatar Apr 13 '18 12:04 nikoskalogridis

interesting that the eslint directive was affecting standard .... anyway fixed it by reordering imports. @briancavalier what is the reason of implementing curry inside the core/src/index.js and not exporting the functions already curried?

nikoskalogridis avatar Apr 13 '18 13:04 nikoskalogridis

Yeah, standard is eslint under the hood and does obey the comment directives.

The reason we only curry at the API boundary is so that internal code doesn't take the extra perf hit (small as it may be) of calling the curried versions.

briancavalier avatar Apr 13 '18 21:04 briancavalier

In order to not leave this PR pending while discussing I propose to open an issue for discussing the curry in the API or module boundary. So I reverted the reordering of imports in this PR. In any case if we decide to change the curry position core/index.js will change a lot

nikoskalogridis avatar Apr 14 '18 10:04 nikoskalogridis

Thanks for reverting the index.js reordering. That'll help us merge this one more quickly!

briancavalier avatar Apr 16 '18 14:04 briancavalier