holmes icon indicating copy to clipboard operation
holmes copied to clipboard

support cgroup v2

Open Curl-Li opened this issue 3 years ago • 5 comments

适配CGroupv2,兼容v1版本,暂未支持混用挂载

Curl-Li avatar Sep 10 '22 09:09 Curl-Li

Hi @Curl-Li, welcome to mosn community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

mosn-community-bot[bot] avatar Sep 10 '22 09:09 mosn-community-bot[bot]

Hi Curl, thanks for your PR, this is a large PR for holmes, I need more time to figure out them, and these changes seems very like automaxprocs/tree/master/internal/cgroups.

It seems to be a common solution, but I'm not sure whether it is related to the Golang version

Jun10ng avatar Sep 14 '22 15:09 Jun10ng

Hi Curl, thanks for your PR, this is a large PR for holmes, I need more time to figure out them, and these changes seems very like automaxprocs/tree/master/internal/cgroups.

It seems to be a common solution, but I'm not sure whether it is related to the Golang version

I referenced part of automaxprocs's code and wrapped it. About issue of version, I tried golang1.9rc1 and golang1.19.1, both are working well.

Curl-Li avatar Sep 26 '22 01:09 Curl-Li

LGTM. It seems standard modifications about CGroups v1/v2.

Jun10ng avatar Jan 09 '23 09:01 Jun10ng

Thanks, I will take a deeper look when I have a long free time.

doujiang24 avatar Jan 09 '23 11:01 doujiang24