holmes

holmes copied to clipboard

一点小建议

1

var buf bytes.Buffer _ = pprof.Lookup("xxx").WriteTo(&buf, int(h.opts.DumpProfileType)) 几秒就要运行一次 此处的 buffer是否可以搞成复用呢，不然这样不停的分配，又不停的回收, 这会不会成为性能点， 可能理解的不对

Owen-Zhang

heap samples are not what I expect

4

### What version of Go are you using (`go version`)? $ 1.17.8 ### Does this issue reproduce with the latest release? Haven't tried. ### What operating system and processor architecture...

dumbFeng

optimize: we can skip goroutine dump when already finished a thread check dump in a single loop.

2

since thread check dump already contains a goroutine profile. Feel free to assign yourself(or request to assign to you.) if you are interested.

doujiang24

bug: win环境下dump的文本出现乱码

4

win环境下，enable holmes，dump之后查看文本，出现乱码，不确定是不是bug

Howie59

support viewcore and make it better to use. https://github.com/golang/debug/tree/master/cmd/viewcore

taoyuanyuan

https://github.com/avelino/awesome-go

taoyuanyuan

Don’t let user pay for what they don’t need

1

Split the stats collect function, if only memory dump is enabled, don’t collect stats other than rss

cch123

- we can get allgs by go:linkname [demo](https://github.com/cch123/test/commit/bc0b4072d7297602d89ac066173501b2df700d15) - can print all goroutines with goroutine id by debug/pprof/goroutine?debug=2 So we can output every goroutine stack size

cch123

deadlock detection

1

investigate for deadlock detection, if plenty of goroutines block on lock acquire, is it a deadlock? if goroutines stack matches some rules, is it a deadlock? if runtime_SemacquireMutex numbers keep...

cch123

https://github.com/grantseltzer/weaver

cch123