moshensky
Possibility to support ssim.js?
Bases on arguments mentioned in the jest-image-snapshot repo, it seems like ssim.js could be a better algorithm to use in some use cases.
Just wanna check if there is any plan or interest to integrate it?
Hi @Songyu-Wang, it could be an interesting exercise. Before doing it thou, it would be nice to have some comparison in speed and quality between the two libs. I'd appreciate if you are interested in providing such comparison with some sample data.
@moshensky Thanks for you reply! At the moment I have not been able to use neither of the tools you mentioned above since right now I am just trying to read about different tools to find some candidates to POC for our use case. Your tool definitely stands out, but we also really like the ssim approach even tho we would have to built in house wrapper for the pdf processing part of the framework.
So unfortunately I dont have any speed and quality data for you. However, I can see that ssim repo has e2e tests which took 156.099 s to run in the most recent passing build . I hope this is data point to show you the speed seems reasonable. As for the quality, given the stats, I assume it is at minimum good enough.
Separately, I would argue that speed is not the top attribute I am looking for. Since visual testing is known for fragile and take lots of efforts to setup and maintain on a daily base for any active projects. I highly doubt the majority of users are using it "at scale". Assume the claim of reduced false positives is true, I would be very happy if I can cut down the manual response works related to false positives even tho at the cost of speed in automated runs.
Also, just to clarify, this issue is not to ask you replace jimp with ssim. All I am hoping for is to have a second comparison algorithm as an alternative to use.
I might look into it as soon as I get a bit of free time. For sure I can't make any promises for the next two weeks. All contributions are much appreciated.
Sounds reasonable to me. My intention was just to see if it's on the roadmap. Your plan to act is already more than I was hoping for
I don’t have immediate plans to implement this functionality at the moment, so I’ll be closing the issue for now. If anyone would like to see this feature added in the future, feel free to comment or reopen the issue.
Please note that ssim.js is archived.
I don’t have immediate plans to implement this functionality at the moment, so I’ll be closing the issue for now. If anyone would like to see this feature added in the future, feel free to comment or reopen the issue.
Please note that ssim.js is archived.
I don’t have immediate plans to implement this functionality at the moment, so I’ll be closing the issue for now. If anyone would like to see this feature added in the future, feel free to comment or reopen the issue.
Please note that ssim.js is archived.