react-native-pull-to-refresh icon indicating copy to clipboard operation
react-native-pull-to-refresh copied to clipboard

please make it more ES6-able

Open kaminskypavel opened this issue 9 years ago • 2 comments

cool package!

I'd apprecuate if you could user export instead of module.exports.

specificallt in node_modules\react-native-pull-to-refresh\index.js if you can change line number 5 to `export var PTRView = false;' that'd be great.

tip : use eslint for code linting.

kaminskypavel avatar Feb 17 '16 22:02 kaminskypavel

@kaminskypavel Thank you for your issue and any hint to improve!

I will update this component based on your idea in a few days :smile_cat:

moschan avatar Feb 18 '16 01:02 moschan

@kaminskypavel I thought, It is not better because If I use export, we cannot use the component like this: var PTRView = require('react-native-pull-to-refresh')

react-native is also using module.exports. https://github.com/facebook/react-native/blob/master/Libraries/react-native/react-native.js#L133

What do you think about?

moschan avatar Feb 19 '16 14:02 moschan