gvm icon indicating copy to clipboard operation
gvm copied to clipboard

Fix incorrect path reformatting issue

Open Heunsig opened this issue 1 year ago • 5 comments

I have fixed an issue in the __gvm_munge_path() function located in the ~/.gvm/scripts/function/munge_path file. Previously, paths containing spaces were being incorrectly parsed, leading to problems such as /AppData/Local/Programs/Microsoft:VS:Code/bin:/snap/bin, where colons (:) were inserted into the path names.

Because of this, after installing gvm, some terminal commands would result in a "command not found" error.

To resolve this, I updated the script to enclose each path in double quotes ("") when adding them to the array. This ensures paths with spaces are handled correctly.

This fix should solve the following issues: https://github.com/moovweb/gvm/issues/486#issue-2433874341, https://github.com/moovweb/gvm/issues/487#issue-2444729848, https://github.com/moovweb/gvm/issues/466#issue-2165852612

Heunsig avatar Aug 08 '24 13:08 Heunsig

Can we please get this merged?

pmhofman-se avatar Sep 27 '24 10:09 pmhofman-se

Can we please get this merged?

Looks like the main contributor hasn't had a chance to review this yet

Heunsig avatar Sep 27 '24 16:09 Heunsig

Has this repo been abandonned when Edgio took over Moov?? Maybe better continue with a fork then....

pmhofman-se avatar Oct 30 '24 14:10 pmhofman-se

@BenKnigge, are you still maintaining this project?

pmhofman-se avatar May 13 '25 10:05 pmhofman-se

@BenKnigge can this be mergedd pretty please?

This is a fatal bug rendering GVM useless when triggered.

weakcamel avatar Jun 20 '25 08:06 weakcamel