moonlight-android icon indicating copy to clipboard operation
moonlight-android copied to clipboard

feat: Add `Guide menu` to on-screen virtual controller

Open mattvgm opened this issue 2 years ago • 2 comments

Description

In some games/applications the guide menu(or Xbox button) is actually important, for example when using Steam Big Picture this button opens the big picture's menu to tweak controller,exit game, etc...

This PR adds to the On-screen virtual controller the Guide Menu (The name can be changed) between the START and BACK buttons.

It also adds a configuration for the ones that want to hide it and don't need to use it.

Motivation

Personally this helps me 100% as my second generic gamepad does not have this button and I have other combos mapped to BACK + START.I would even add a configuration to only have this button, but I think maybe the PR #1247 already address it in a good way.

Tested with both #1247 and #1171 and works perfectly, no conflicts and made my experience better

Screenshot

guide_menu

mattvgm avatar Oct 23 '23 01:10 mattvgm

I am really looking forward to it as it will be a game changer for those using the app to connect to Batocera OS where the button acts like hotkey for several functionality.

jk7gr avatar Apr 08 '24 15:04 jk7gr

@jk7gr I've been using for a while and it works fine for me.

@cgutman When you have time can you please give it a look on this PR. If it is something you consider good I can improve it further if necessary. Thanks

mattvgm avatar Apr 11 '24 17:04 mattvgm

@ReenigneArcher Thank you for the feedback and thank you for the Sunshine project, is a fantastic project.

I agree with all the changes to keep the code consistence. I'll be around for anything, thanks

mattvgm avatar Jul 25 '24 17:07 mattvgm