pool icon indicating copy to clipboard operation
pool copied to clipboard

Check the existence of a Dockerfile on target revision.

Open tf0054 opened this issue 11 years ago • 3 comments

If the pool cannot find the appropriate container, the pool will forward our browser to the building screen and start the building without checking the existence of a Dockerfile on the target repo top.

tf0054 avatar Dec 23 '14 02:12 tf0054

And maybe it makes inside dockers' ip address inconsistency problem.

tf0054 avatar Dec 23 '14 02:12 tf0054

Thanks for reporting the issue 🙏 I figured out this problem as seeing the errors when cloning repository without Dockerfile in pool system. Errors below;

I, [2014-12-22T15:31:55.064284 #56]  INFO -- : FATA[0000] no Dockerfile found in /app/images/workspace/77e94cf6b46ed196e1e1de1ca6d8f01b9cd03d3f 


I, [2014-12-22T15:31:55.064818 #56]  INFO -- : image_id is /app/images/workspace/77e94cf6b46ed196e1e1de1ca6d8f01b9cd03d3f

I, [2014-12-22T15:31:55.084880 #56]  INFO -- : Write image id <> and commit id <77e94cf6b46ed196e1e1de1ca6d8f01b9cd03d3f> to /app/images/ids

To fix the bug, we should implement the exception handling about build error. Ref. exception handling is implemented here.

ainoya avatar Dec 23 '14 07:12 ainoya

After supporting #53, docker-api ruby client may returns various exceptions, then we'll be able to care this problem more easily with the exception handling.

ainoya avatar Dec 23 '14 07:12 ainoya