Proof-Pudding icon indicating copy to clipboard operation
Proof-Pudding copied to clipboard

Suggest to loosen the dependency on alive_progress

Open Agnes-U opened this issue 3 years ago • 0 comments

Dear developers,

Your project Proof-Pudding requires "alive_progress==1.2.0" in its dependency. After analyzing the source code, we found that the following versions of alive_progress can also be suitable without affecting your project, i.e., alive_progress 1.1.0, 1.1.1. Therefore, we suggest to loosen the dependency on alive_progress from "alive_progress==1.2.0" to "alive_progress>=1.1.0,<=1.2.0" to avoid any possible conflict for importing more packages or for downstream projects that may use ddos_script.

May I pull a request to further loosen the dependency on alive_progress?

By the way, could you please tell us whether such dependency analysis may be potentially helpful for maintaining dependencies easier during your development?



Details:

Your project (commit id: 18d327d0483a2b67387b364fb7bfe2308ba99c8e) directly uses 1 APIs from package alive_progress.

alive_progress.progress.alive_bar

Beginning fromwhich, 14 functions are then indirectly called, including 2 alive_progress's internal APIs and 12 outsider APIs as follows:

[/moohax/Proof-Pudding]
+--alive_progress.progress.alive_bar
|      +--alive_progress.configuration.create_config
|      |      +--copy.deepcopy
|      +--datetime.timedelta
|      +--sys.__stdout__.write
|      +--alive_progress.spinners.spinner_player
|      +--time.sleep
|      +--sys.__stdout__.flush
|      +--threading.Lock
|      +--time.time
|      +--threading.Event
|      +--sys.stdout.isatty
|      +--threading.Thread
|      +--math.log10
|      +--math.ceil

Since all these functions have not been changed between any version for package "alive_progress" from [1.1.0, 1.1.1] and 1.2.0. Therefore, we believe it is safe to loosen the corresponding dependency.

Agnes-U avatar Nov 30 '22 18:11 Agnes-U