monodevelop icon indicating copy to clipboard operation
monodevelop copied to clipboard
verified publisher icon mono

Fix 29887 take 2

Open iainx opened this issue 10 years ago • 3 comments

This is the more generic version of https://github.com/mono/monodevelop/pull/995 where the TextEditor has implemented the IKeyHandler interface, which the command manager then checks to see if the text editor is currently overriding the key press.

Fixes the issues where Escape wouldn't close the Insert Extracted Method overlay, or wouldn't close the autocompletion dialog if it was assigned to a command. (Bug 29887)

It also prevents essential keys from being overridden if they are assigned to a command such as alphanumeric keys or Tab, Return or Backspace.

iainx avatar Jul 31 '15 18:07 iainx

This lgtm.

Therzok avatar Aug 22 '15 14:08 Therzok

It looks ok to me. @mkrueger can you review?

slluis avatar Aug 24 '15 08:08 slluis

I think that shadows a problem somewhere else. It used to work AFAIK. What about other components than the text editor ?

Other than that it'll work that way. But it looks like we're digging a hole here that gets deeper :/. However I don't know enough about the command manager problem and how it can be resolved. Merge if really nothing other will help.

mkrueger avatar Sep 18 '15 12:09 mkrueger