monkeytype icon indicating copy to clipboard operation
monkeytype copied to clipboard

Added a new quote.

Open triach-rold opened this issue 1 year ago • 6 comments

Description

Just gave the credits to the original author of the quote. This is a common misattribution. Source.

triach-rold avatar May 04 '24 04:05 triach-rold

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Added a new quote.". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - build
 - chore
 - ci
 - docs
 - feat
 - impr
 - fix
 - perf
 - refactor
 - revert
 - style
 - test

github-actions[bot] avatar May 04 '24 04:05 github-actions[bot]

Added a new quote from Friedrich Nietzsche.

triach-rold avatar May 04 '24 04:05 triach-rold

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/8983579016

monkeytypegeorge avatar May 07 '24 10:05 monkeytypegeorge

Please fix incorrect quote length and PR title

Miodec avatar May 08 '24 12:05 Miodec

Please fix incorrect quote length and PR title

Quote length and PR title has been fixed, as requested @Miodec

triach-rold avatar May 14 '24 20:05 triach-rold

Please resolve conflicts

Miodec avatar May 20 '24 10:05 Miodec

Please change the pr title to something like impr(quotes): added a new quote(triach-rold) We do this so we can easily understand what area the change focuses on, and then allows the release system to list the changes in the release notes.

Warrobot10 avatar May 30 '24 05:05 Warrobot10

Closing due to inactivity

Miodec avatar Jun 03 '24 10:06 Miodec