monkeytype icon indicating copy to clipboard operation
monkeytype copied to clipboard

style: Change csv file name when saving data (vjgtigers)

Open vjgtigers opened this issue 1 year ago • 2 comments

Description

when downloading history it saves as a csv file but the data is not separated by commas. while most csv viewers can still read it, it could cause a little bit of confusion. This pull request changes the file extension to dsv (delimiter separated values) and changed "Export CSV" to "Export History". However changing "item.charStats" and "item.tags" to be joined by a different delimiter and changing the main delimiter to commas would also work and could keep the csv extension.

vjgtigers avatar Mar 23 '24 17:03 vjgtigers

I'd prefer changing the delimiter.

Google docs and Excel do not support | as delimiter. LibreOffice does support |. If we would use ; as delimiter it would work in google docs, excel and libreOffice.

LibreOffice and Google Docs don't support dsv.

fehmer avatar Mar 23 '24 17:03 fehmer

What if we change the main delimiter to be a "," and change the delimiter for "item.charStats" and "item.tags" to be something like "|" or ";". This way we keep the csv file extension and should be readable by most csv readers.

vjgtigers avatar Mar 23 '24 18:03 vjgtigers

Is this PR still needed if we change the delimiter to be a comma?

Miodec avatar Mar 25 '24 11:03 Miodec

Closing as mentioned by the author in a different pr

Miodec avatar Mar 25 '24 11:03 Miodec