mongo-python-driver icon indicating copy to clipboard operation
mongo-python-driver copied to clipboard
verified publisher icon mongodb

PYTHON-4521 Example transition of an existing test to an async one

Open NoahStapp opened this issue 1 year ago • 4 comments

This PR shows the work required to convert https://github.com/mongodb/mongo-python-driver/blob/8fbf84d314d18c2ce6e897e5d1bdd21f2493e409/test/test_logger.py to be asynchronous as well as generate the synchronous version.

NoahStapp avatar Jun 25 '24 15:06 NoahStapp

Can we remove the top level test_logger.py as part of this?

blink1073 avatar Jun 25 '24 16:06 blink1073

Can we remove the top level test_logger.py as part of this?

Good point, I've added automated running of the test/synchronous directory to https://github.com/mongodb/mongo-python-driver/pull/1699 so we can start removing the top-level test files as they're converted. Once that's merged I'll remove the top-level test_logger.py here.

NoahStapp avatar Jun 25 '24 16:06 NoahStapp

@NoahStapp this should be ready for an update now.

blink1073 avatar Jul 01 '24 18:07 blink1073

@NoahStapp this should be ready for an update now.

Updated, still need https://github.com/mongodb/mongo-python-driver/pull/1718 to be merged for the final version.

NoahStapp avatar Jul 01 '24 20:07 NoahStapp