chatbot icon indicating copy to clipboard operation
chatbot copied to clipboard

(EAI-532) [UI] Fix spacing for headings and lists

Open nlarew opened this issue 1 year ago • 1 comments

Jira: (EAI-532) [UI] Fix spacing for headings and lists Screenshot 2024-10-02 at 5 45 27 PM Screenshot 2024-10-02 at 5 45 37 PM Screenshot 2024-10-02 at 5 45 46 PM

nlarew avatar Oct 02 '24 22:10 nlarew

i think the spacing between list items now looks strangely big. what was the reason for this change?

mongodben avatar Oct 04 '24 20:10 mongodben

i think the spacing between list items now looks strangely big. what was the reason for this change?

@mongodben This is the base styles from LG Chat. I removed some of our hacky negative margin stuff in this PR because more edge cases came up. Still not sure why our list items spread out this much but I think it's (a) not terrible and (b) less complicated to use the out of the box styles rather than hacking around every edge case.

nlarew avatar Oct 07 '24 19:10 nlarew

i think the spacing between list items now looks strangely big. what was the reason for this change?

@mongodben This is the base styles from LG Chat. I removed some of our hacky negative margin stuff in this PR because more edge cases came up. Still not sure why our list items spread out this much but I think it's (a) not terrible and (b) less complicated to use the out of the box styles rather than hacking around every edge case.

maybe get sign off from liz before merge + deploy?

i'm totally supportive of not hacking around edge cases, but i really think it looks off. maybe at least we could make a ticket for LG chat, or bring to their attention so they can address upstream w/o you having to hack

Screenshot 2024-10-08 at 3 38 11 PM

mongodben avatar Oct 08 '24 19:10 mongodben