boxednode icon indicating copy to clipboard operation
boxednode copied to clipboard

fix: address `-Wpessimizing-move` warning in binary blob helpers

Open addaleax opened this issue 1 year ago • 0 comments

Fixes:

../src/node_main.cc:945:52: warning: moving a temporary object prevents copy elision
    std::vector<char>* str = new std::vector<char>(std::move(GetBoxednodeCodeCacheVector()));
                                                  ^
../src/node_main.cc:945:52: note: remove std::move call here
    std::vector<char>* str = new std::vector<char>(std::move(GetBoxednodeCodeCacheVector()));
                                                  ^~~~~~~~~~                             ~
../src/node_main.cc:986:52: warning: moving a temporary object prevents copy elision
    std::vector<char>* str = new std::vector<char>(std::move(GetBoxednodeSnapshotBlobVector()));
                                                  ^
../src/node_main.cc:986:52: note: remove std::move call here
    std::vector<char>* str = new std::vector<char>(std::move(GetBoxednodeSnapshotBlobVector()));

addaleax avatar Dec 12 '24 15:12 addaleax