Player icon indicating copy to clipboard operation
Player copied to clipboard

API / Intent definition

Open brentonv opened this issue 4 years ago • 10 comments

Hi

Just curious to know if there are any plans to implement activity results such as in MX , VLC , or Vimu

Thanks

brentonv avatar Nov 07 '21 07:11 brentonv

Part of the MX Player API (which includes Activity result) is already implemented to allow integration with Nova Video Player - #158.

What specific API methods/parameters you have in mind (only Activity results or also something else)? What other software uses this API and in what use cases? (This also helps when testing the integration)

moneytoo avatar Nov 07 '21 07:11 moneytoo

Oh cool thanks, MX activity results are fine. I'm just looking to see how this integrates with another player that also handles MX activity results so I'll do some tests and let you know how it goes

Thanks

brentonv avatar Nov 07 '21 09:11 brentonv

I did see there are MX intents used in Just Player which is absolutely brilliant but as you said it’s only part of the MX API. The only functions I could get to work were play and resume. External subtitles do not load (via API) and there seems to be no results returned for resume position other than “playbackFinished”, as there is no “intent.result.VIEW" only “intent.action.VIEW" implemented. It would be greatly appreciated if you could please consider using the following MX intents:

"intent.action.VIEW"
__"video_list"
__"video_list.name"
__"video_list.filename"
__"subs"
__"subs.enable"
__"title"
__"filename"
__"position"
__"return_result"
__"headers"

"intent.result.VIEW"
__"position"
__"duration"
__"end_by"
____"user"
____"playback_completion"🙏

brentonv avatar Nov 10 '21 05:11 brentonv

Nice to see some updates here. I'll test it out and let you know. Thanks @moneytoo

brentonv avatar Feb 10 '22 01:02 brentonv

Around version 0.67 when I logged this issue I created a Just Player test build as a default player with the Syncler app, and API support was limited.

I see by version 0.99 the requested changes have finally been implemented which I really appreciate, and this has also made way for the Syncler developer to include Just Player as a new default player which will also please many others.

The player position intent works and now enables resume playback from the Syncler app which is excellent, but as you're aware there are still issues with downloaded subtitles in the Syncler BETA so I'm yet to fully confirm this part.

However one thing I did notice in the meantime is Just Player doesn't display the subtitle language for the downloaded subtitle and instead shows "Unknown". The split screen image compares the current Syncler/BETA/Exo player with Just Player

BrokenSuntitles

brentonv avatar Feb 13 '22 07:02 brentonv

However one thing I did notice in the meantime is Just Player doesn't display the subtitle language for the downloaded subtitle and instead shows "Unknown".

Does it work with other players?

moneytoo avatar Feb 13 '22 14:02 moneytoo

Does it work with other players?

With the downloaded subtitle feature being so problematic at the moment I can't really test anything. The language flag is probably missing from the Syncler app when it sends details to the player so I'll post this to /r/SynclerApp also

brentonv avatar Feb 15 '22 04:02 brentonv

It doesn't seem like there's a field for language in the MX Player API. For example Jellyfin puts the language name as a label to subs.name.

moneytoo avatar Feb 15 '22 07:02 moneytoo

Jellyfin puts the language name as a label to subs.name.

I've posted the issue to /r/SynclerApp so hopefully the Syncler developer can implement something similar for you to use.

Thanks again for all the great work you do

brentonv avatar Feb 15 '22 07:02 brentonv

Also it would be great if Just Player would pass a unique action string when creating the result intent (new Intent(uniqueResultAction), so that it would be possible to identify that the result is coming from Just Player. Here are a few action names used by other player:

MX - com.mxtech.intent.result.VIEW MPV - is.xyz.mpv.MPVActivity.result VLC - org.videolan.vlc.player.result

TheBeastLT avatar Mar 23 '22 20:03 TheBeastLT