monero-python icon indicating copy to clipboard operation
monero-python copied to clipboard

Multisignature support

Open johndoe123445 opened this issue 6 years ago • 12 comments

Hello,

Thanks for the great work you’ve done there.

As you may know, monero v0.13.0.4 has finally stabilized M-N multisig of monero.

The JSON RPC has create_wallet, prepare_multisig, make_multisig, finalize_multisig to create a multisignature wallet.

Can you implement that feature to this wonderful library? I would like to help, but the creation is too complicated for the api to expose the methods clean.

Thanks.

johndoe123445 avatar Mar 07 '19 22:03 johndoe123445

https://blog.keys.casa/a-monero-multisig-users-guide/

https://www.getmonero.org/resources/developer-guides/wallet-rpc.html#make_multisig

johndoe123445 avatar Mar 07 '19 22:03 johndoe123445

Definitely, multisig has been a part of the plan from the very beginning. As you see, the task is not trivial though. At the moment I can't give any time estimate when it could be done.

MMS also looks to be interesting feature to have implemented, as an add-on: https://rbrunner7.github.io/mms_full_manual

emesik avatar Mar 08 '19 09:03 emesik

How about just a just simple wrapper for these?

create_wallet prepare_multisig make_multisig finalize_multisig

johndoe123445 avatar Mar 13 '19 02:03 johndoe123445

Not so easy. The Wallet class is designed to run a single wallet only. We would need a WalletManager or some other higher-level handler for create_wallet. You may look for something similar in this project. Be aware, however, that code is highly experimental and crashes/hangs on IPC quirks very often.

Also, signing of transactions must be implemented, and we should distinguish signed and unsigned txs. I touched the topic in unsigned-tx branch but had no more time to work on it.

Certainly, it is an important feature but we need it to be designed well. If you, or anyone else, find the code in monerowalletpool useful here, I'm willing to release necessary parts under BSD license too.

emesik avatar Mar 13 '19 09:03 emesik

What's the development status of the multisig feature?

ghost avatar Jun 12 '20 06:06 ghost

Not progressing. I'd love to have time to spend on it.

emesik avatar Jun 13 '20 21:06 emesik

is there any progress on monero multi sig support ?

h0ay avatar Mar 13 '22 16:03 h0ay

None. I'm going to release 1.0 soon as there are no outstanding bug reports. Then I'll focus on new features but recently I don't have much time to spend on it.

emesik avatar Mar 14 '22 10:03 emesik

Lemme know if i can help you in anyway ,donations ,contributions

h0ay avatar Mar 16 '22 08:03 h0ay

Actually I'm thinking about applying for funding. However, first I need to carve out time to read docs and estimate the effort.

emesik avatar Mar 16 '22 09:03 emesik

That's cool Message me when you need the hep

h0ay avatar Mar 17 '22 10:03 h0ay

any discord or instant messaging contact ? I could help you to get it started

h0ay avatar Mar 31 '22 12:03 h0ay