Add role "combobox" to Combobox component

Open hadasfa opened this issue 4 years ago • 4 comments

Add role: "combobox" to the input element of the Combobox component

Oct 11 '21 12:10 hadasfa

Hi @hadasfa, I'd love to take this up

Oct 11 '21 12:10 vivek32ta

@vivek32ta Sure :) Let's do this. I'll check your PR when it's ready.

Oct 11 '21 14:10 hadasfa

@vivek32ta do you still working on this PR?

Oct 14 '21 11:10 hadasfa

@hadasfa Yes yes. I am. I was just confused a bit with the codebase. This is the first time I'm working on a UI package. Sorry, please excuse me for the delay. I was stuck if I have to add the role in just Combobox component or add it to its child components as well, like Search and TextArea, because there is no role attribute in the props passed.

Oct 14 '21 15:10 vivek32ta

Combo box component renders a Search input which has a default role value search.

Do we need to customize the Search prop structure to give the required role in Combo box?

Oct 08 '22 19:10 aayushbisen