FLINT icon indicating copy to clipboard operation
FLINT copied to clipboard

Fix:56 Extendable Land Unit Area

Open kartikeysaran opened this issue 4 years ago • 13 comments

This PR Fixes #56

kartikeysaran avatar Mar 09 '21 08:03 kartikeysaran

@kartikeysaran

I couldn't determine any contributions to add, did you specify any contributions? Please make sure to use valid contribution names.

allcontributors[bot] avatar Mar 09 '21 08:03 allcontributors[bot]

@kartikeysaran

I couldn't determine any contributions to add, did you specify any contributions? Please make sure to use valid contribution names.

allcontributors[bot] avatar Mar 09 '21 08:03 allcontributors[bot]

@kartikeysaran

I couldn't determine any contributions to add, did you specify any contributions? Please make sure to use valid contribution names.

allcontributors[bot] avatar Mar 09 '21 08:03 allcontributors[bot]

@kartikeysaran

I couldn't determine any contributions to add, did you specify any contributions? Please make sure to use valid contribution names.

allcontributors[bot] avatar Mar 09 '21 08:03 allcontributors[bot]

@all-contributors please add <@kartikeysaran> for

kartikeysaran avatar Mar 09 '21 08:03 kartikeysaran

@kartikeysaran

I couldn't determine any contributions to add, did you specify any contributions? Please make sure to use valid contribution names.

allcontributors[bot] avatar Mar 09 '21 08:03 allcontributors[bot]

@all-contributors please add @kartikeysaran for code

kartikeysaran avatar Mar 09 '21 08:03 kartikeysaran

@kartikeysaran

I've put up a pull request to add @kartikeysaran! :tada:

allcontributors[bot] avatar Mar 09 '21 08:03 allcontributors[bot]

@shubhamkarande13 - could you please take a look at this? @kartikeysaran - you might need to add some explanation how your changes fix the issue.

aornugent avatar Mar 25 '21 20:03 aornugent

@kartikeysaran @leitchy would like to allow the user to define a variable that points to the Area to be used, which can be changed in the config file with "landUnitAreaVariable": "spatial_layer_area",.

Your commit does not involve the functionality to get this variable from the config file. 👎🏼 Please come try to come up with an alternative solution!

Cheers!

shubhamkarande13 avatar Mar 27 '21 01:03 shubhamkarande13

Thanks @shubhamkarande13 - do you have an example of how config variables are used? Perhaps in FLINT.example?

aornugent avatar Mar 28 '21 01:03 aornugent

@kartikeysaran Please have a look at the config files. Base test module RothC module

shubhamkarande13 avatar Mar 28 '21 08:03 shubhamkarande13

@kartikeysaran Please have a look at the config files. Base test module RothC module

Okay will update the code accordingly

kartikeysaran avatar Apr 03 '21 07:04 kartikeysaran