FLINT-UI icon indicating copy to clipboard operation
FLINT-UI copied to clipboard

Bug: RothC page crashes if table is displayed before simulation finishes

Open Crystalsage opened this issue 3 years ago • 1 comments

Describe the bug.

When we go to /flint/configurations/rothc and click Run quickly followed by Point Output Table button , the whole thing crashes without any warnings or indicators. We would like to handle this more gracefully.

Refer to bug report #369. The behavior is pretty much the same including the stack trace.

Describe the steps to reproduce the behavior.

  1. Head over to /flint/configurations/rothc.
  2. Click Run.
  3. Immediately click Point Output Table.

Expected behavior.

Handle this more gracefully and display an error notification if the simulation hasn't finished yet.

Screenshots.

No response

Operating Environment

Arch Linux 5.18, Firefox, Ran locally with API deployed on azurewebsites.

Additional Information

No response

Crystalsage avatar Sep 16 '22 05:09 Crystalsage

I'll take this up myself.

Crystalsage avatar Oct 08 '22 15:10 Crystalsage

Hola @Palaksharma23 I am working in this issue :)

ConnectBhawna avatar Jan 16 '23 11:01 ConnectBhawna

Sure, go ahead :)

Palaksharma23 avatar Jan 16 '23 16:01 Palaksharma23

Hii @Crystalsage is this issue solved? When I run it in my local system it is not showing me any crash if the table is displayed before the simulation finishes

ConnectBhawna avatar Jan 22 '23 10:01 ConnectBhawna

Hi @Bhawna1203. Sorry for the late reply, but yes the bug still exists. I was able to reproduce it without connecting to the actual FLINT API.

Here's how I reproduced it:

  1. Run the FLINT-UI on localhost.
  2. Visit /flint/configurations/rothc
  3. Click the Run button.
  4. Click the Show Output button.
  5. Check the console. The following stack trace was present.
Uncaught TypeError: (intermediate value).split is not a function
    parse_RothC_results rothc.js:529
    wrappedActionHandler vuex.esm-browser.js:305
    dispatch vuex.esm-browser.js:1031
    boundDispatch vuex.esm-browser.js:914
    showRothCOutputContainer ConfigurationsRothC.vue:164
    0 ConfigurationsRothC.vue:66

Crystalsage avatar Jan 25 '23 11:01 Crystalsage

Okk Awesome Got it, I am working on solving this issues. Thanks for letting me know this

ConnectBhawna avatar Jan 25 '23 12:01 ConnectBhawna