core icon indicating copy to clipboard operation
core copied to clipboard

feat(dts-plugin): add IPV6 property to DTS Plugin

Open RussellCanfield opened this issue 1 year ago • 11 comments

Added IPv6 property to the DTS plugin

#3382

RussellCanfield avatar Jan 02 '25 02:01 RussellCanfield

🦋 Changeset detected

Latest commit: 05c700a8db4ad85f34650fd314bbe1fb0883a6a4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@module-federation/dts-plugin Major
@module-federation/sdk Major
@module-federation/enhanced Major
@module-federation/manifest Major
@module-federation/rspack Major
@module-federation/devtools Major
@module-federation/data-prefetch Major
@module-federation/esbuild Patch
@module-federation/managers Major
@module-federation/modern-js Major
@module-federation/nextjs-mf Patch
@module-federation/node Patch
@module-federation/retry-plugin Major
@module-federation/rsbuild-plugin Major
@module-federation/runtime-core Patch
@module-federation/runtime Major
@module-federation/storybook-addon Major
@module-federation/utilities Patch
@module-federation/webpack-bundler-runtime Major
@module-federation/bridge-react-webpack-plugin Major
@module-federation/bridge-react Major
@module-federation/bridge-vue3 Major
@module-federation/modernjsapp Patch
@module-federation/runtime-tools Major
@module-federation/inject-external-runtime-core-plugin Major
@module-federation/third-party-dts-extractor Major
@module-federation/bridge-shared Major
@module-federation/error-codes Major
website-new Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jan 02 '25 02:01 changeset-bot[bot]

Deploy Preview for module-federation-docs ready!

Name Link
Latest commit 05c700a8db4ad85f34650fd314bbe1fb0883a6a4
Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/677d5193f347f4000850de37
Deploy Preview https://deploy-preview-3421--module-federation-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jan 02 '25 02:01 netlify[bot]

@2heal1 - I know you are assigned this issue, but how do you feel about this new setting?

RussellCanfield avatar Jan 02 '25 02:01 RussellCanfield

i see both node.js and axios use family to specify the ipversion , can we keep the same with them

2heal1 avatar Jan 02 '25 02:01 2heal1

i see both node.js and axios use family to specify the ipversion , can we keep the same with them

I think we can safely just omit the { family } object when its ipv6, but explicitly setting it should be fine. Right now it will just set family to 4 or 6 based on the new DTS config param.

The http agent is passed to axios, so axios will respect what the underlying agent is configured to. Is there another location to look for nodejs?

RussellCanfield avatar Jan 02 '25 15:01 RussellCanfield

Emm i want to follow the standard named options because if new ipversion coming the useIpv6 can not be extend easily

2heal1 avatar Jan 03 '25 03:01 2heal1

Emm i want to follow the standard named options because if new ipversion coming the useIpv6 can not be extend easily

Updated :)

RussellCanfield avatar Jan 03 '25 16:01 RussellCanfield

Hi ,do you ready to merge ?

2heal1 avatar Jan 15 '25 08:01 2heal1

Hi ,do you ready to merge ?

I've been testing this a little bit and it seems it still requires setting the rspack dev server to a host value of 127.0.0.1, at least in my case.

I'm thinking it's more on the host side than the requesting side or possibly both. Need to test more

RussellCanfield avatar Jan 15 '25 13:01 RussellCanfield

Hi ,do you ready to merge ?

I've been testing this a little bit and it seems it still requires setting the rspack dev server to a host value of 127.0.0.1, at least in my case.

I'm thinking it's more on the host side than the requesting side or possibly both. Need to test more

Got , when you ready to merge just pin me

2heal1 avatar Jan 22 '25 06:01 2heal1

Hi @RussellCanfield , just wanted to kindly follow up on this PR 😊 I’ve been looking forward to this feature and noticed it’s been open for a little while. From the last update, it sounds like some testing was still in progress—just wondering if there’s any update or anything blocking the merge?

Appreciate all the work you’re doing—thanks in advance!

Jianrong-Yu avatar Mar 22 '25 05:03 Jianrong-Yu

Stale pull request message

github-actions[bot] avatar May 21 '25 15:05 github-actions[bot]