core icon indicating copy to clipboard operation
core copied to clipboard

feat: support node esmodule and mf-manifest esmodule

Open zhangHongEn opened this issue 1 year ago • 6 comments

Description

Supports importing remote files in esm format in the node environment

Related Issue

https://github.com/module-federation/vite/issues/73

Types of changes

  • [ ] Docs change / refactoring / dependency upgrade
  • [x] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)

Checklist

  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.
  • [ ] I have updated the documentation.

zhangHongEn avatar Sep 08 '24 15:09 zhangHongEn

⚠️ No Changeset found

Latest commit: 24317ec94467109bb3b3b48eda93667ecd032c3f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Sep 08 '24 15:09 changeset-bot[bot]

Deploy Preview for module-federation-docs ready!

Name Link
Latest commit 24317ec94467109bb3b3b48eda93667ecd032c3f
Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/66f87b7537f5b600086319b6
Deploy Preview https://deploy-preview-2934--module-federation-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Sep 08 '24 15:09 netlify[bot]

please run nx:format write

ScriptedAlchemy avatar Sep 09 '24 21:09 ScriptedAlchemy

please run nx:format write

Thanks, it's now complete. I've run the fix on my home computer before, but it didn't take effect.

zhangHongEn avatar Sep 10 '24 02:09 zhangHongEn

In the browser environment, This demo can verify this error viteViteRemote@https://unpkg.com/mf-vite-remote/dist/mf-manifest.json

zhangHongEn avatar Sep 12 '24 08:09 zhangHongEn

@ScriptedAlchemy Is there anyone who can help handle this PR?

zhangHongEn avatar Sep 19 '24 03:09 zhangHongEn

Moving to internal branch to help

ScriptedAlchemy avatar Sep 28 '24 21:09 ScriptedAlchemy

Moving to internal branch to help

ScriptedAlchemy avatar Sep 28 '24 21:09 ScriptedAlchemy