code icon indicating copy to clipboard operation
code copied to clipboard

add user hover cards and ext. link warnings

Open NoahCxrest opened this issue 9 months ago • 2 comments

this is my first PR, so i probably made a few mistakes. here's what i've done:

add user hover cards to relevant components

Screenshot 2025-03-30 at 12 50 21 PM Screenshot 2025-03-30 at 12 50 33 PM these are meant to be as unintrusive as possible and remove when the user scrolls. it takes 150ms for it to start loading the assets required for it on hover of a user-link.

add external link warnings

Screenshot 2025-03-30 at 12 52 05 PM this checks if the user is visiting a link that is outside of the modrinth scope and gives them a warning if they are.

NoahCxrest avatar Mar 30 '25 18:03 NoahCxrest

the command/ctrl+k menu is a fully localizable command menu that opens when a user presses the command/ctrl + k keybind. Screenshot 2025-03-30 at 3 09 57 PM

https://github.com/user-attachments/assets/f2743f48-f0e6-4523-a476-9e3ccdb0ea7f

NoahCxrest avatar Mar 30 '25 21:03 NoahCxrest

This is awesome, hope this gets merged soon!

imheavi avatar Mar 31 '25 12:03 imheavi

Lots of great stuff in this pull request, would you be able to split it up into separate PRs though?

IMB11 avatar May 29 '25 13:05 IMB11

Lots of great stuff in this pull request, would you be able to split it up into separate PRs though?

Could take a while. If absolutely necessary, sure.

NoahCxrest avatar May 29 '25 14:05 NoahCxrest

Appreciate the contribution! A large PR like this with many unrelated features will likely not get merged, however, since the design and code review it would take is likely unjustifiable. If you'd like to reopen any of these features in the future as individual PRs, please do keep them small in scope and be prepared for both design and code reviews that may require significant changes.

Prospector avatar Jul 10 '25 04:07 Prospector