code icon indicating copy to clipboard operation
code copied to clipboard

library icons size change when clicking them

Open millennIumAMbiguity opened this issue 1 year ago • 5 comments

Describe the bug

when right or left-clicking an item in the library, the size changes of the items. (only happens at specific resolutions) When the scale doesn't change, the scrollbar still changes its size.

Steps to reproduce

  1. right or left-clicking an item in the library

Expected behavior

library to stay the same size

System information

Windows 11 screen: 3440x1440

Additional context

No response

millennIumAMbiguity avatar Apr 29 '24 16:04 millennIumAMbiguity

https://github.com/modrinth/theseus/assets/37588844/f01c8adb-02c8-4c76-95ea-527dbecec3a4

millennIumAMbiguity avatar Apr 29 '24 16:04 millennIumAMbiguity

Can reproduce it even on smaller screen size (1366x768). Seems like it's reproduceable only with latest string icons and last icon in pre-last string for every category, and it makes sense as you have only one string:

https://github.com/modrinth/theseus/assets/65756919/945612d5-2bfc-434b-8250-314a0adce58c

https://github.com/modrinth/theseus/assets/65756919/33996a91-c3b4-4114-b294-15cb48db2675

Version 0.7.1, Windows 11

w26ad avatar Apr 29 '24 20:04 w26ad

All other cards get scaled up when clicking on an instance on the last row, it doesn't happen on the other rows. I can reproduce this on v0.7.1 with 3840x2160 resolution.

yesseruser avatar Jun 08 '24 05:06 yesseruser

Can confirm

https://github.com/modrinth/theseus/assets/75726196/86da5044-ebaf-4ca0-a794-55526fd07950

Felix14-v2 avatar Jun 10 '24 21:06 Felix14-v2

This is what I've made out with dev tools:

  1. Initially, the elements with the class .instance have a height of 218 px.
  2. When any .instance-card-item is active, the height of all the cards, including the active one, changes to 678 px (which seems to be the viewport height).
  3. After becoming inactive, the height remains at 678 px.
  4. Upon becoming active again, their height changes to 217 px. This change occurs every time afterwards, alternating between 678 px when not active and 217 px when active.

yesseruser avatar Jun 13 '24 19:06 yesseruser