Improve travis test with TOXENV

[kryskool]

Description of the issue/feature this PR addresses:

Use TOXENV with travis

[tonioo]

@kryskool Looks like travis build has not been triggered?

[ghost]

The travis.yml syntax is incorrect, TOXENV needs to be under env -> matrix (where DB used to be)

You'll also have issues with Python > 3.4 not being installed as Travis only installs the python version specified in the python setting (2.7 and 3.4 are installed by default in Debian)

On April 13, 2018 7:08:50 AM UTC, Antoine Nguyen [email protected] wrote:

@kryskool Looks like travis build has not been triggered?

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/modoboa/modoboa/pull/1465#issuecomment-381044897

[kryskool]

Hi @fyfe

Your right, i rewrite the .travis.yml file. it works now

Regards,

[kryskool]

Hi @tonioo

It's seem there is a problem with entities in Python 3 and SQLite

FAIL: test_map_upgrade (modoboa.admin.tests.test_mapfiles.MapFilesTestCase)
Check that map content is used.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/modoboa/modoboa/.tox/py35-dj111-sqlite/lib/python3.5/site-packages/modoboa/admin/tests/test_mapfiles.py", line 49, in test_map_upgrade
    self.assertEqual(mapcontent["dbpath"], dbsettings["NAME"])
AssertionError: 'file:memorydb_default?mode=memory&cache=shared' != 'file:memorydb_default?mode=memory&cache=shared'
- file:memorydb_default?mode=memory&cache=shared
?                                   ----
+ file:memorydb_default?mode=memory&cache=shared

Regards,

[ghost]

@kryskool the Django 2 builds are using Django 1.11.12

https://travis-ci.org/modoboa/modoboa/jobs/366485787#L628

py35-dj20-postgres installed: [cut],Django==1.11.12,[cut]

[kryskool]

@fyfe thnaks for the review

yes i prefer your solution, i change my code

@kryskool the Django 2 builds are using Django 1.11.12 https://travis-ci.org/modoboa/modoboa/jobs/366485787#L628

I must check the tox.ini file

Regards,

[kryskool]

I think we must protect password if containt HTML entities

[gawel]

Hi. In django-webtest I've created a py script to convert tox -l to a travis conf: https://github.com/django-webtest/django-webtest/blob/master/django_webtest_tests/tox2travis.py Maybe this can work for you too.

[tonioo]

@kryskool I guess we can close this PR. What do you think?