modernjuliaworkflows.github.io icon indicating copy to clipboard operation
modernjuliaworkflows.github.io copied to clipboard

Content for Optimizing Page

Open jacobusmmsmit opened this issue 1 year ago • 4 comments

PR remade to avoid dealing with merge conflicts in things unrelated to new content.

This PR currently covers the basic principles of writing fast-running code (minimise allocations and ensure type stability), along with a bit of why these are the principles. As well as this, it explains how (and why) to use BenchmarkTools.

jacobusmmsmit avatar Mar 12 '24 14:03 jacobusmmsmit

can you fix the conflicts with main to see if it builds remotely?

gdalle avatar Apr 28 '24 13:04 gdalle

Error comes from trying to display a static array. Weird.

jacobusmmsmit avatar Apr 28 '24 18:04 jacobusmmsmit

I would open a Xranklin issue?

gdalle avatar Apr 28 '24 21:04 gdalle

It's worked for us in the past, I suppose :')

jacobusmmsmit avatar Apr 28 '24 22:04 jacobusmmsmit

@gdalle @adrhill things that need to be fixed before merge:

  • "SIMD and GPU programming" is not finished, do we keep what is already there or just wait till it's all done. I favour the latter.
  • What is going on with my #hideall at the top of the page? It's not hiding the output.
  • Macros like @benchmark have a return value and so they don't print the pretty graph when the code is run.

jacobusmmsmit avatar May 29 '24 17:05 jacobusmmsmit

Macros like @benchmark have a return value and so they don't print the pretty graph when the code is run.

Maybe this here is the answer? https://franklinjl.org/code/#inserting_the_output Specifically the \show part

gdalle avatar May 29 '24 19:05 gdalle

I don't know what I'm doing wrong but I can't make that work :/

Even using the example from the page I get:

┌ Warning: Command '\output' used before it was defined.
└ @ Xranklin ~/.julia/packages/Xranklin/6wt1L/src/convert/markdown/latex_objects.jl:62

jacobusmmsmit avatar May 30 '24 10:05 jacobusmmsmit

Maybe it's different in Xranklin than Franklin?

gdalle avatar May 30 '24 12:05 gdalle

I took care of the #hideall

gdalle avatar May 30 '24 12:05 gdalle

Working on the review, made my way to the end of "benchmarking"

gdalle avatar May 30 '24 13:05 gdalle