FunASR icon indicating copy to clipboard operation
FunASR copied to clipboard

Fix path mistake in FunASR/runtime/python /onnxruntime/README.md and fix python dependence mistake of funasr_onnx

Open Yan-Xiangjun opened this issue 3 months ago • 1 comments

“FunASR/funasr/runtime/python/onnxruntime”是一个不存在的路径,在执行“cd FunASR”之后,如果用户再执行“cd funasr/runtime/python/onnxruntime”会出现错误。

虽然funasr_onnx用到了onnxruntime,但实际上它并未用到onnx库。(仅安装funasr_onnx,不安装完整的funasr Python包,是不需要import onnx的)但onnx出现在了install_requires中。

jieba库未出现在install_requires中,但 FunASR/runtime/python/onnxruntime/funasr_onnx/utils/utils.py 使用到它了。

"FunASR/funasr/runtime/python/onnxruntime" is an invalid path. After executing "cd FunASR", if the user executes "cd funasr/runtime/python/onnxruntime", an error will occur.

Although funasr_onnx uses onnxruntime, it does not actually use onnx. (If only funasr_onnx is installed, without installing the whole funasr Python package, there is no need to import onnx) However, onnx appears in the install_requires list.

The jieba package is not included in the install_requires list, but it is used in the file FunASR/runtime/python/onnxruntime/funasr_onnx/utils/utils.py.

Yan-Xiangjun avatar Oct 27 '25 12:10 Yan-Xiangjun

Summary of Changes

Hello @Yan-Xiangjun, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a minor but crucial issue within the onnxruntime module's README.md by rectifying an incorrect installation path. The adjustment ensures that users can successfully navigate to the onnxruntime directory after cloning the repository, thereby preventing errors during the setup process and streamlining the installation experience.

Highlights

  • Installation Path Correction: Corrected an invalid directory path in the onnxruntime module's README.md installation instructions, changing funasr/runtime/python/onnxruntime to FunASR/runtime/python/onnxruntime.
  • Command Separation: Separated the git clone and cd FunASR commands into distinct lines within the installation guide for improved clarity and execution flow.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Oct 27 '25 12:10 gemini-code-assist[bot]